Opened 8 years ago

Closed 8 years ago

#14242 closed defect (wontfix)

[IconItem] Default onClick Behavior Should NOT be an Open Box

Reported by: Ming Zhe Huang Owned by: ykami
Priority: high Milestone:
Component: DojoX Mobile Version: 1.7.0
Keywords: Cc: Atsushi Ono
Blocked By: Blocking:

Description

Please try the attached test case.
This also comes from a customer case. Currently we have 4 clicking behaviors of IconItem?:

  • define innerHTML: show it in an open box.
  • 'moveTo': transit to a view
  • 'href': load the remote HTML
  • 'url': pull in the remote HTML

But if we do NONE of above for the IconItem?, it will still open a box after clicking. I think this is not a correct behavior:

  1. we already have an explicit way of an open box.
  2. In many cases, what people want is none of the 4 behaviors provided. Instead, they want a custom behavior like popping up a dialog or showing some text after clicking. The formal way is to define nothing but to register a click handler. However, the default behavior breaks them all.

I suggest we should do nothing if there's no innerHTML, 'moveTo', 'href' or 'url'.

Attachments (1)

icon-empty.html (946 bytes) - added by Ming Zhe Huang 8 years ago.
test case

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Ming Zhe Huang

Attachment: icon-empty.html added

test case

comment:1 Changed 8 years ago by ykami

Cc: Atsushi Ono added

comment:2 Changed 8 years ago by Atsushi Ono

We have moveTo="#" option for this purpose. Nothing happens (except icon highlight) when you click the IconItem with moveTo="#" parameter, which is in common with ListItem.

comment:3 in reply to:  2 Changed 8 years ago by Ming Zhe Huang

Replying to onoat:

We have moveTo="#" option for this purpose. Nothing happens (except icon highlight) when you click the IconItem with moveTo="#" parameter, which is in common with ListItem.

Thanks. Are you going to further change the default behavior? If not, then please feel free to close it.

comment:4 Changed 8 years ago by ykami

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.