[IconItem] Connect "iconClicked" and it will be triggered twice

[Ming Zhe Huang]

Please try the attached test case.
If we use dojo/_base/connect to connect to "iconClicked", the alert dialog will be popped up twice. This cause some trouble for custom event handling, because there's no "onclick" of ListItem? and we rely on "iconClicked" to monitor clicking event.

[Ming Zhe Huang]

test case

[Atsushi Ono]

IconItem#iconClicked is called twice during a click event for a reason now. In your case, how about connecting to the iconNode's "onclick" event handler as below?

dojo.connect(iconItemWidget.iconNode, "onclick", function(e) { ... });

[Ming Zhe Huang]

Replying to onoat:

IconItem#iconClicked is called twice during a click event for a reason now. In your case, how about connecting to the iconNode's "onclick" event handler as below?

dojo.connect(iconItemWidget.iconNode, "onclick", function(e) { ... });

This is exactly what I'm doing now :) There's a recursion in iconClicked(). Can we split that part into a new function to avoid duplicated call?

[ykami]

Archer, the recursion is necessary to ensure that the pressed icon color changes before the click action runs. We will change the name of the event handlers, for example from onClick to _onClick, just like dijit, in 1.8.

[Atsushi Ono]

This issue cannot be reproduced any more in the latest code because of the recent changes around onClick event handlers in #14428 (although actual changes for IconItem were committed in #14662).

Now IconItem#iconClicked is renamed to IconItem#_onClick, and you can use IconItem#onClick event handler which should be invoked just once on each click event.