Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#14232 closed defect (fixed)

dojox/mobile/SwapView misbehavior when it contains an input element

Reported by: davliu Owned by: Adrian Vasiliu
Priority: high Milestone: 1.9.1
Component: DojoX Mobile Version: 1.7.0
Keywords: SwapView Cc:
Blocked By: Blocking:

Description (last modified by Adrian Vasiliu)

If a SwapView? contains an input element, while the element has the focus, the background will flash the last SwapView? content. All the input elements, like dojox/mobile/TextBox or TextArea? can reproduce the issue.

Download the attached SwapView?.html to test in the mobile test folder.

Attachments (2)

SwapView.html (4.2 KB) - added by davliu 8 years ago.
ticket14232.patch (849 bytes) - added by Sebastien Brunot 6 years ago.
Do not change view if not scrolling on the X axis (IBM CCLA).

Download all attachments as: .zip

Change History (14)

Changed 8 years ago by davliu

Attachment: SwapView.html added

comment:1 Changed 8 years ago by Adam Peller

Milestone: 1.7.1tbd

comment:2 Changed 7 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:3 Changed 6 years ago by cjolif

Owner: changed from ykami to Eric Durocher
Priority: blockerhigh
Status: newassigned

was automatically moved to blocker, move it back to high

Changed 6 years ago by Sebastien Brunot

Attachment: ticket14232.patch added

Do not change view if not scrolling on the X axis (IBM CCLA).

comment:4 Changed 6 years ago by Sebastien Brunot

I've attached a patch to fix this behaviour.

comment:5 Changed 6 years ago by Adrian Vasiliu

Milestone: tbd1.9.1
Owner: changed from Eric Durocher to Adrian Vasiliu

comment:6 Changed 6 years ago by Adrian Vasiliu

Summary: SwapView contents a input elementdojox/mobile/SwapView misbehavior when it contains an input element

comment:7 Changed 6 years ago by Adrian Vasiliu

Description: modified (diff)

comment:8 Changed 6 years ago by Sebastien Brunot

It appears that the problem is fixed on the current trunk, so I guess this ticket can be closed without applying the patch.

comment:9 Changed 6 years ago by Adrian Vasiliu

sbrunot:

You say it is fixed in the current trunk, is it also fixed in the current 1.9 branch? When you initially reproduced, it was with which Dojo version, and with which browser?

In fact, what was exactly the issue you reproduced? On my side, with either 1.9.0, 1.8.0 or current trunk on iPad 4 iOS 6.1.3, I reproduce a quick flickering on the background of the TextArea. With 1.7 (against which the issue was open), this also produces sometimes a flickering of the entire page - with the next swap view showing up for a little while. That is, I only see a severe glitch with 1.7.0, while on newer versions it's about a short flickering of the text element itself.

On the other side, I can hardly see how the change in your proposed patch relates with a fix for a flickering issue. On the iPad 4, I reproduce the flickering with current trunk, with and without the patch. Maybe you referred to some other issue than this flickering? Please clarify.

Now, independently on that, I would think the patch puts us on the safe side, so I would go for it anyway.

Last edited 6 years ago by Adrian Vasiliu (previous) (diff)

comment:10 Changed 6 years ago by Sebastien Brunot

This patch was authored a month ago, I unfortunately do not remember on which version I reproduced it (I would say it was there on SVN trunk on May 10th 2013 in the morning (french time). What I remember is that I reproduced the exact same issue that is described in this ticket. I think that selecting a input field or a text area was triggering a scroll on the y axis (scrollTo method called with parameter {y: something}), and it doesn't seem to be the case anymore.

comment:11 Changed 6 years ago by Adrian Vasiliu <vasiliu@…>

Resolution: fixed
Status: assignedclosed

In edfbe1ce9e86dfe9242b634aa071c3caa57edd65/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:12 Changed 6 years ago by Adrian Vasiliu <vasiliu@…>

In 1e1cd8da51b9316a4aaae4f3f788679d58acfe9d/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.