Opened 10 years ago

Closed 10 years ago

#14220 closed task (fixed)

[meta] baseless conversion for 1.8

Reported by: bill Owned by:
Priority: high Milestone: 1.8
Component: General Version: 1.7.0
Keywords: Cc:
Blocked By: Blocking:

Description

Ticket for remaining modules that need to be updated to be baseless (i.e. to access functions etc. through module exports rather than through dojo, dijit, and dojox "globals).

See also #13959 about controlling modules to (conditionally) not export values into the dojo, dijit, and dojox "globals".

Change History (6)

comment:1 Changed 10 years ago by bill

In [26967]:

Various updates to modules to not use dojo global variable, except for exporting the modules' symbols. Refs #14220 !strict.

comment:2 Changed 10 years ago by bill

In [26969]:

Updates i18n.js module to not use dojo global variable, except for exporting the module's symbols. Refs #14220, #14211 !strict. Apparently it's no good to reference config.locale, (tests/date/locale fails), so still referencing dojo.locale. That should be fixed at some point.

comment:3 Changed 10 years ago by Mark Wubben

A similar reference in dnd/Moveable, our patch is at <​https://github.com/EqualMedia/dojo/commit/78fc0ccf0475a71fa9aee9b9edb8c5eca0546eb9>. Should I commit this on trunk?

comment:4 Changed 10 years ago by bill

Oh, thanks for catching that, please check it in under #14201 (the ticket I used for the DnD AMD conversion).

comment:5 Changed 10 years ago by Mark Wubben

Done.

comment:6 Changed 10 years ago by bill

Resolution: → fixed
Status: new → closed

Closing this... the remaining old-style modules that get carried over to 2.0 will (by necessity) be converted then.

Note: See TracTickets for help on using tickets.