Opened 11 years ago
Closed 11 years ago
#14211 closed defect (fixed)
dojo/i18n doesn't load dojo/xhr (but it needs to)
Reported by: | bill | Owned by: | ben hockey |
---|---|---|---|
Priority: | high | Milestone: | 1.7.1 |
Component: | Internationalization | Version: | 1.7.0 |
Keywords: | Cc: | Rawld Gill, Adam Peller | |
Blocked By: | Blocking: |
Description (last modified by )
dojo.requireLocalization() ends up calling dojo.xhr() but without loading the dojo/_base/xhr.
Apply attached patch to make i18n.js baseless, and then run util/doh/runner.html?test=dojo/tests/date/locale, which does a dojo.requireLocalization() call. It will get an exception.
The issue is that i18n.js has a dependency:
"./has!dojo-v1x-i18n-Api?./_base/xhr"
but dojo-v1x-i18n-Api isn't defined until later in that i18n.js file:
has.add("dojo-v1x-i18n-Api", // if true, define the v1.x i18n functions 1 );
Chicken and egg problem.
Broke in [25690] so assigning to Ben.
Attachments (1)
Change History (8)
Changed 11 years ago by
Attachment: | i18n_baseless.patch added |
---|
comment:1 Changed 11 years ago by
Description: | modified (diff) |
---|
comment:6 Changed 11 years ago by
Yes, after it's backported to the 1.7 branch.
There's still the issue of converting i18n.js to baseless, which I'll do on trunk, and also a missing reference to dojo/_base/config, but that missing reference is benign since kernel.js pulls in config.js.
patch moving towards i18n.js being baseless (but it still has some dojo references)