Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#14201 closed task (fixed)

convert DnD code to baseless and minimal dependencies

Reported by: bill Owned by: bill
Priority: high Milestone: 1.8
Component: DnD Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description


Change History (10)

comment:1 Changed 8 years ago by bill

Type: defecttask

comment:2 Changed 8 years ago by bill

Resolution: fixed
Status: newclosed

In [26959]:

Convert DnD code to have granular dependencies and to be baseless.

These files are still pretty messy, as they don't obey namespaces well. For example, Container.js adds multiple symbols to dojo.dnd, in addition to defining the Container class.

Also removing these lines from mover.js, which do nothing given the typos of "Mover" instead of "Moveable":

dojo.dnd.constrainedMover = dojo.dnd.move.constrainedMover;
dojo.dnd.boxConstrainedMover = dojo.dnd.move.boxConstrainedMover;
dojo.dnd.parentConstrainedMover = dojo.dnd.move.parentConstrainedMover;

And also, some lint and spelling fixes.

Fixes #14201 !strict.

comment:3 Changed 8 years ago by liucougar

In [26988]:

refs #14201: topic.unsubscribe is not available any more

!strict

comment:4 Changed 8 years ago by Mark Wubben

In [27054]:

Fix dojo reference in dnd/Moveable. Refs #14201

comment:5 Changed 8 years ago by bill

In [27950]:

remove lingering dojo reference, refs #14201 !strict.

comment:6 Changed 7 years ago by bill

In [28250]:

stray dojo reference, refs #14201 !strict

comment:7 Changed 7 years ago by bill

In [30372]:

convert DND test files to AMD, and stop using deprecated APIs, refs #14201

comment:8 Changed 7 years ago by bill

In [30373]:

more conversion of DND test files to AMD, refs #14201

comment:9 Changed 7 years ago by bill

In [30375]:

fix AMD conversion error and use data-dojo-type, refs #14201

comment:10 Changed 7 years ago by bill

In [30404]:

need to wait for parser to finish before accessing c4, especially since dojo/dnd/Target is being auto-required, refs #14201

Note: See TracTickets for help on using tickets.