Opened 9 years ago
Closed 9 years ago
#14196 closed defect (fixed)
_base/fx.js Dependency Issue
Reported by: | David Walsh | Owned by: | bill |
---|---|---|---|
Priority: | blocker | Milestone: | 1.7.1 |
Component: | General | Version: | 1.7.0 |
Keywords: | fx | Cc: | |
Blocked By: | Blocking: |
Description
In updating tutorials for the 1.7 update, I ran into issues with Tooltip and fx.slideTo. In both cases, the animation that was meant to occur (Tooltip's opacity and slideTo's top/left) were not animation properly or not at all with "async: true". This led me to believe there was a dependency issue.
In tracing through the code, I discovered this in _base/fx.js:
connect.connect(anim, "onAnimate", lang.hitch(dojo, "style", anim.node));
As dojo.style is defined in html.js, and html.js is not a dependency, this is a major issue. The following will correct the problem:
connect.connect(anim, "onAnimate", lang.hitch(style, "set", anim.node));
Since fx.js is used often, this should be a high priority issue.
Attachments (1)
Change History (3)
Changed 9 years ago by
Attachment: | fix-fx-deps.patch added |
---|
comment:2 Changed 9 years ago by
Owner: | set to bill |
---|---|
Resolution: | → fixed |
Status: | new → closed |
In [26955]:
Patch