_base/fx.js Dependency Issue

[David Walsh]

In updating tutorials for the 1.7 update, I ran into issues with Tooltip and fx.slideTo. In both cases, the animation that was meant to occur (Tooltip's opacity and slideTo's top/left) were not animation properly or not at all with "async: true". This led me to believe there was a dependency issue.

In tracing through the code, I discovered this in _base/fx.js:

connect.connect(anim, "onAnimate", lang.hitch(dojo, "style", anim.node));

As dojo.style is defined in html.js, and html.js is not a dependency, this is a major issue. The following will correct the problem:

connect.connect(anim, "onAnimate", lang.hitch(style, "set", anim.node));

Since fx.js is used often, this should be a high priority issue.

[David Walsh]

Patch

[bill]

In [26954]:

fix typo in baseless conversion on trunk, refs #14196 !strict

[bill]

In [26955]:

fix typo in baseless conversion on 1.7 branch, fixes #14196 !strict