mobile listItem callback function can't be called when clicking it to start transition to another view

[davliu]

In dojo mobile 1.6.1, if I specify the callback method when creation mobile listItem and make transition to other view by clicking the item, the callback method will be fired, and in the onBeforeTransitionOut stub method of the view, the context, method param will filled with the item node and callback method. However, the same code can not run in dojo 1.7, it just ignore the callback and context is null as well.

I attached the 2 file for comparison, one for 1.6 and another for 1.7. put them to the relevant dojo mobile test folder and check the console.

[Atsushi Ono]

[patch][ccla] ViewController fix

[Atsushi Ono]

It seems that ListItem's callback feature has been unexpected omitted when view transition architecture was switched to use ViewController in 1.7. I attached a patch to fix ViewController#onStartTransition to pass the context and callback arguments properly to call View#performTransition.

[ykami]

Thank you onoat for the patch. I think your observation is correct.

[ykami]

In [27162]:

Fixes #14186 !strict. If a widget that initiated the transition has a callback, pass it to View.performTransition(). This was a regression bug introduced during the view transition refactoring.

[Adam Peller]

since this is a regression, please consider backporting to 1.7.3.

[Atsushi Ono]

[patch][ccla] ViewController fix for 1.7.3

[Atsushi Ono]

I have attached a patch for 1.7.x stream. I confirmed that the same fix committed to 1.8 stream before in [27162] can also work fine for 1.7.3.

[ykami]

In [28206]:

Fixes #14186 !strict. Back-port to 1.7.x. If a widget that initiated the transition has a callback, pass it to View.performTransition(). This was a regression bug introduced during the view transition refactoring. Thanks onoat for the patch.