Opened 9 years ago
Closed 9 years ago
#14186 closed defect (fixed)
mobile listItem callback function can't be called when clicking it to start transition to another view
Reported by: | davliu | Owned by: | ykami |
---|---|---|---|
Priority: | high | Milestone: | 1.7.3 |
Component: | DojoX Mobile | Version: | 1.7.0 |
Keywords: | transition, callback, context | Cc: | Atsushi Ono |
Blocked By: | Blocking: |
Description
In dojo mobile 1.6.1, if I specify the callback method when creation mobile listItem and make transition to other view by clicking the item, the callback method will be fired, and in the onBeforeTransitionOut stub method of the view, the context, method param will filled with the item node and callback method. However, the same code can not run in dojo 1.7, it just ignore the callback and context is null as well.
I attached the 2 file for comparison, one for 1.6 and another for 1.7. put them to the relevant dojo mobile test folder and check the console.
Attachments (4)
Change History (12)
Changed 9 years ago by
Attachment: | test_transition-connect_1_6_1.html added |
---|
Changed 9 years ago by
Attachment: | test_transition-connect_1_7.html added |
---|
Changed 9 years ago by
Attachment: | 14186.patch added |
---|
comment:1 Changed 9 years ago by
It seems that ListItem's callback feature has been unexpected omitted when view transition architecture was switched to use ViewController in 1.7. I attached a patch to fix ViewController#onStartTransition to pass the context and callback arguments properly to call View#performTransition.
comment:2 Changed 9 years ago by
Milestone: | tbd → 1.7.1 |
---|---|
Status: | new → assigned |
Thank you onoat for the patch. I think your observation is correct.
comment:4 Changed 9 years ago by
Milestone: | 1.7.1 → 1.8 |
---|
comment:5 Changed 9 years ago by
Milestone: | 1.8 → 1.7.3 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
since this is a regression, please consider backporting to 1.7.3.
comment:6 Changed 9 years ago by
Cc: | Atsushi Ono added |
---|
Changed 9 years ago by
Attachment: | 14186_1.7.3.patch added |
---|
[patch][ccla] ViewController fix for 1.7.3
comment:7 Changed 9 years ago by
I have attached a patch for 1.7.x stream. I confirmed that the same fix committed to 1.8 stream before in [27162] can also work fine for 1.7.3.
[patch][ccla] ViewController fix