Opened 8 years ago

Closed 7 years ago

#14153 closed defect (fixed)

dojo/test/i18n not working in rhino

Reported by: haysmark Owned by: Rawld Gill
Priority: high Milestone: 1.8
Component: TestFramework Version: 1.6.1
Keywords: dohfail Cc: Chris Mitchell
Blocked By: Blocking:

Description (last modified by Rawld Gill)

In util/doh, create a config.js to set async to true:

dojoConfig = {
async: true
}
load(["../../dojo/dojo.js"]);

The following fails:

java -jar ../shrinksafe/js.jar config.js baseUrl=../../dojo load=doh test=dojo/tests/i18n

Change History (8)

comment:1 Changed 8 years ago by Douglas Hays

Cc: Chris Mitchell added

comment:2 Changed 8 years ago by Rawld Gill

That test (dojo/tests/i18n) is a browser-based test. It won't work in Rhino.

I debugged enough to know that require is being defined (that's a typically-useless rhino artificat).

I'm not sure if it's important to get this test working on rhino; leaving open for more feedback on that (and until I can look more).

comment:3 Changed 8 years ago by Rawld Gill

Component: LoaderTestFramework
Priority: highnormal
severity: majornormal

comment:4 Changed 8 years ago by Rawld Gill

Description: modified (diff)
Summary: require() not defined by async loaderdojo/test/i18n not working in rhino

comment:5 Changed 8 years ago by haysmark

The test script is dojo/tests/i18n.js. I don't think the first test that fails, salutations-de, requires the browser to work?

But yeah, something very wrong is happening in dojo/i18n.js; the require not being defined is one of the arguments to doLoad, not necessarily the loader's require.

comment:6 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:7 Changed 8 years ago by bill

Keywords: dohfail added

comment:8 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [28478]:

added nonbrowser path to i18n; fixed test; fixes #14153; !strict

Note: See TracTickets for help on using tickets.