Changes between Version 1 and Version 2 of Ticket #14147, comment 3


Ignore:
Timestamp:
Oct 25, 2011, 12:59:23 AM (10 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14147, comment 3

    v1 v2  
    11I see, yes subtracting the marginBox size of Dialog.domNode from the contentBox size of Dialog.containerNode probably makes sense.
    22
    3 As for _size(), there is code monitoring viewport resize:
    4 
    5 {{{
    6 this._modalconnects.push(on(window, "resize", lang.hitch(this, function(){
    7         // IE gives spurious resize events and can actually get stuck
    8         // in an infinite loop if we don't ignore them
    9         var viewport = winUtils.getBox();
    10         if(!this._oldViewport ||
    11                         viewport.h != this._oldViewport.h ||
    12                         viewport.w != this._oldViewport.w){
    13                 this.layout();
    14                 this._oldViewport = viewport;
    15         }
    16 })));
    17 }}}
    18 
    19 Not sure why it isn't working.
    20 
     3I'll add the _size() call to layout().
    214
    225BTW, in the future it would be better if you could file a separate ticket for each issue.