Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#14144 closed defect (fixed)

Canvas events fire on wrong object

Reported by: yehuda Owned by: Patrick Ruzand
Priority: high Milestone: 1.7.1
Component: DojoX GFX Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

In some complex graphics scenarios, Canvas events are fired on the wrong object. In the demo below, clicking on the left button triggers the event that is bound to the right button. Further more: Clicking over the blank space between the buttons also triggers the event on the right button. If djConfig is changed to "gfxRenderer:'svg,canvas'" everything works fine. The issue can be seen on Android 2.x, desktop Safari, Firefox and Chrome.

The two versions are available for online testing here:

http://yehudab.com/apps/dojo/dojo-release-1.7.0rc1-src/dojox/gfx/demos/events-canvas.html

http://yehudab.com/apps/dojo/dojo-release-1.7.0rc1-src/dojox/gfx/demos/events-svg.html

Code is also available in the attached file

Attachments (2)

events-canvas.html (1.5 KB) - added by yehuda 8 years ago.
Minimal test case
14144.patch (2.3 KB) - added by Patrick Ruzand 8 years ago.
Will commit the fix once the trunk will be reopen. Meanwhile, here's a patch (pruzand, CCLA) that fixes the issue.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by yehuda

Attachment: events-canvas.html added

Minimal test case

comment:1 Changed 8 years ago by Chris Mitchell

Owner: changed from Eugene Lazutkin to Patrick Ruzand

Changed 8 years ago by Patrick Ruzand

Attachment: 14144.patch added

Will commit the fix once the trunk will be reopen. Meanwhile, here's a patch (pruzand, CCLA) that fixes the issue.

comment:2 Changed 8 years ago by Patrick Ruzand

Status: newassigned

comment:3 Changed 8 years ago by Chris Mitchell

Milestone: tbd1.7.1

comment:4 Changed 8 years ago by Chris Mitchell

please fix this in 1.7.1 as well as trunk

comment:5 Changed 8 years ago by Patrick Ruzand

Resolution: fixed
Status: assignedclosed

In [27003]:

fixes #14144 _hitTestPixel should clear the ctx first.

comment:6 Changed 8 years ago by Patrick Ruzand

In [27004]:

refs #14144 _hitTextPixel should clear the ctx first

comment:7 Changed 7 years ago by Rawld Gill

In [30928]:

enhance i18n so that bundles include the meta property $locale which indicates the most-specific bundle actually available and loaded (compared to requested and synthesized); thanks peller; fixes #14144; !strict

comment:8 Changed 7 years ago by Rawld Gill

[30928] was for 15144, not this ticket.

Note: See TracTickets for help on using tickets.