Some CSS cascading import url() not processed well after build

[Evan]

Just came across this issue when dealing with #14110. Not sure if it's a more general issue in our util/build.

​EnhancedGrid.css imports content from ​claroGrid.css, and there are some css attributes referring to resources in dijit/dojo e.g

.claro .dojoxGridExpandoLoading .dojoxGridExpandoNode {
  background-image: url('../../../dijit/themes/claro/images/loadingAnimation.gif');
}

After built, all the content in ​claroGrid.css are pulled into ​EnhancedGrid.css, but the above refering path is wrongly changed to

.claro .dojoxGridLoading {
  background-image:url(../dijit/themes/claro/images/loadingAnimation.gif);
}

The expected result should be

.claro .dojoxGridLoading {
  background-image:url(../../../../../dijit/themes/claro/images/loadingAnimation.gif);
}

The incorrect converted patch can be found in either ​1.7RC1 or ​nightly build by searching keyword ".claro .dojoxGridLoading"

So this results in some test pages not working well under dojox/grid/ due to the missed icon resources.

[ben hockey]

#14108 seems related

[ben hockey]

fyi - while looking at this i found that there is an url for .claro .dojoxGridMasterHeader in the source dojox/grid/resources/claroGrid.css that doesn't point to an existing image - ../../../resources/images/header.png

[ben hockey]

there is a problem with fileUtils.compactPath where the following occurs:

fileUtils.compactPath("../../../resources/../../../dojo/resources/images/dndNoCopy.png");

// produces

'../dojo/resources/images/dndNoCopy.png'

// should be

'../../../../../dojo/resources/images/dndNoCopy.png'

[ben hockey]

got a fix...

../build/fileUtils.js

@@ -62 +62 @@
                                if(segment==".." && result.length && lastSegment!=".."){
                                        result.pop();
                                }else if(segment!="."){
-                                       result.push(lastSegment= segment);
+                                       result.push(segment);
                                } // else ignore "."
+                               lastSegment = segment;
                        }
                        return result.join("/");
                },

[ben hockey]

... but this introduces other problems.

[Rawld Gill]

Replying to neonstalwart:

... but this introduces other problems.

What else are you seeing;

Your fix looks fine. This is what is in dojo.js...somehow that code didn't make it here.

[ben hockey]

if you went with the other patch and checked the output file release/dojo/dojox/grid/enhanced/resources/claro/EnhnacedGrid.css it didn't inline it's import. i've fixed it now though - just this patch on its own:

../build/fileUtils.js

@@ -60 +60 @@
                        while(path.length){
                                segment= path.shift();
                                if(segment==".." && result.length && lastSegment!=".."){
-                                       result.pop();
+                                       lastSegment = result.pop();
                                }else if(segment!="."){
                                        result.push(lastSegment= segment);
                                } // else ignore "."

[ben hockey]

aargh... i need to quit rushing this - just do what's in dojo.js. everything else i've said so far is not completely right :)

[ben hockey]

../build/fileUtils.js

@@ -61 +61 @@
                                segment= path.shift();
                                if(segment==".." && result.length && lastSegment!=".."){
                                        result.pop();
+                                       lastSegment = result[result.length - 1];
                                }else if(segment!="."){
                                        result.push(lastSegment= segment);
                                } // else ignore "."

[Rawld Gill]

In [26899]:

fixed compact path to look like dojo.js; fixes #14128; !strict

[Evan]

In [26900]:

Refs #14128 - fix 1 line of incorrect icon refer in dojox/grid/resources/claroGrid.css

[Evan]

Replying to neonstalwart:

fyi - while looking at this i found that there is an url for .claro .dojoxGridMasterHeader in the source dojox/grid/resources/claroGrid.css that doesn't point to an existing image - ../../../resources/images/header.png

Thanks Ben! And it's fixed with [26900]