builder fails silently (exit code is still 0)

[liucougar]

add the following line into a js file, make sure that file is built by builder

s.replace(/[-\\/.+()|]/g, function(x){ return "\\" + x; });

build will fail with the following error:

{ stack: [Getter/Setter],
  arguments: undefined,
  type: undefined,
  message: 'Socket is not writable' }
Error: Socket is not writable
    at Socket._writeOut (net.js:391:11)
    at Socket.write (net.js:377:17)
    at Object.write (build/transforms/writeOptimized:177:21)
    at build/transforms/writeOptimized:131:29
    at build/transforms/writeOptimized:274:5
    at Array.0 (build/transforms/writeOptimized:282:11)
    at build/main:128:23
    at build/main:107:5
    at build/transforms/writeAmd:178:5
    at build/node/fs:23:9

but it does not actually specify what's the problem (I had to add the following line into runner.stderr.on("data", function(data){:

console.error('-------------- '+data);

the build definitely fails, but the exit code is still 0

[Colin Snover]

Builder also does not return a non-zero exit code when the optimizer reports errors, even though the number of errors is logged and available.

[Rawld Gill]

See also #15393, which is basically a dup.

[Rawld Gill]

In [29087]:

improve reporting of optimizer errors; fixes #14127; !strict