Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14121 closed enhancement (fixed)

[patch] simplifying object inheritance and doc update to dojox/css3/transit*

Reported by: zhangyp Owned by: Adam Peller
Priority: high Milestone: 1.8
Component: Dojox Version: 1.7.0b1
Keywords: Cc: Chris Mitchell, nic
Blocked By: Blocking:

Description

This patch remove the dependency to dojo/_base/declare in dojox/css3/transition and use the simple javascript object inheritance. It also update the doc in the code.

Attachments (1)

css3.svn.patch (11.6 KB) - added by zhangyp 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by zhangyp

Attachment: css3.svn.patch added

comment:1 Changed 8 years ago by Adam Peller

Cc: nic added
Milestone: 1.71.8

comment:2 Changed 8 years ago by zhangyp

Adam,

If I interpret this correctly, we do not accept any change for the upcoming dojo 1.7 right now? I created these modules (dojox/css3/transit*) for conducting transition in dojox/app using CSS Transition and CSS Transform. If it is possible, I still hope this change can be made in 1.7 because it does not change any function API and I have verified its quality with dojox/app.

If code freeze is the ground rule that cannot be broken, I hope it can be made to the 1.8 branch as soon as it is created.

comment:3 Changed 8 years ago by Adam Peller

We're way past code freeze, sorry. We're building release candidates and trying to ship 1.7. Only critical fixes are considered right now. It can certainly be checked in as soon as trunk is open for 1.8.

comment:4 Changed 8 years ago by zhangyp

Adam,

Since the 1.7 is code complete, when do you think that this patch can be applied?

comment:5 Changed 8 years ago by Adam Peller

I generally prefer for module owners to check in patches. nic, there are no tests. This project shouldn't be marked as beta until there are tests.

comment:6 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: newclosed

In [26953]:

Patch from zhangyp fixes #14121 \!strict

comment:7 Changed 8 years ago by zhangyp

I have test applications in dojox/app and will create separate unit tests for these two modules I submitted.

comment:8 Changed 8 years ago by zhangyp

refer to ticket #14200 for creating tests.

Note: See TracTickets for help on using tickets.