[patch][cla]use module.url for hint to vm.runInThisContext

[ben hockey]

in node.js the url hint that is passed to vm.runInThisContext needs to be the full path to the file url in order for breakpoints to work in "visual" debuggers such as cloud9. changing the hint passed to require.eval to be module.url rather than module.id fixes this. this also causes the browser debuggers that use ////@ sourceURL= to show the url rather than the module id - i could argue both ways as to which one is better in that case.

this patch would fix it:

dojo.js

@@ -1212 +1212 @@
                                                if(text===cached){
                                                        cached.call(null);
                                                }else{
-                                                       req.eval(text, module.mid);
+                                                       req.eval(text, module.url);
                                                }
                                        }catch(e){
                                                signal(error, makeError("evalModuleThrew", module));
@@ -1221 +1221 @@
                                        if(text===cached){
                                                cached.call(null);
                                        }else{
-                                               req.eval(text, module.mid);
+                                               req.eval(text, module.url);
                                        }
                                }
                                injectingCachedModule = 0;

[Rawld Gill]

In [27836]:

improved debugging hint for node; thanks neonstalwart; fixes #14115; !strict

[Rawld Gill]

in [27836], added the has feature "dojo-loader-eval-hint-url"`, which, when truthy, will cause the module url to be used for the eval hint in the loader. This feature defaults to true for node and false for other environments (it seems the module id is easier to use in the browser), but, of course, can be hard-set by a user if they prefer one or the other.

By using a has feature, the builder can strip this code to save a few bytes.

[Rawld Gill]

In [27837]:

make dojo-loader-eval-hint-url overrideable by user config; refs #14115; !strict

[Rawld Gill]

In [27838]:

backport #14115 fixes; !strict; refs #14115