Calling dojo/domstyle.getComputedStyle on svg elements fails under IE9

[Patrick Ruzand]

Calling dojo/domstyle.getComputedStyle on svg elements fails under IE9. The problem seems to come from the getComputedStyle impl., that assumes the currentStyle property is defined for all nodes of type Element under IEs:

}else if(has("ie")){

getComputedStyle = function(node){ IE (as of 7) doesn't expose Element like sane browsers return node.nodeType == 1 /* ELEMENT_NODE*/ ? node.currentStyle : {};

};

This is not true when the node is an SVG element. In this case, currentStyle is not defined (window.getComputedStyle shouldn't be used instead in the case currentStyle is undefined ?).

Attached a simple testcase to be put in the dojo distrib root directory. It works on the other browsers (FF7, Chrome).

[Patrick Ruzand]

test file, to be put in the dojo distrib root directory

[Adam Peller]

should get this in as an automated test

[Kenneth G. Franqueiro]

This bug is reproducible on older versions of dojo as well; bumping to 1.8 as such. I'll attach a version of the test that can reproduce this on 1.6.

[Kenneth G. Franqueiro]

version of test runnable against non-AMD versions of dojo

[Kenneth G. Franqueiro]

I should clarify that if we do find a fix for this, I'd totally be for backporting it as far as we see fit for the sake of fixing browser compatibility.

[Patrick Ruzand]

Note that this bug prevent the gfx bidi extension to run under IE9 (run the dojox/gfx/tests/_gfxBidiSupport/testBidi.html *in IE9 standard mode*)

[Kenneth G. Franqueiro]

I'll be committing the fix for this as well as adding a test to dojo/tests/_base/html.html in trunk and branches for 1.5 through 1.7.

[Kenneth G. Franqueiro]

In [27116]:

Fix dojo.getComputedStyle code path for IE9; fixes #14103 on trunk

[Kenneth G. Franqueiro]

In [27117]:

Fix dojo.getComputedStyle code path for IE9; fixes #14103 on 1.7 branch

[Kenneth G. Franqueiro]

In [27118]:

Fix dojo.getComputedStyle code path for IE9; fixes #14103 on 1.5 branch !strict

[Kenneth G. Franqueiro]

In [27119]:

Fix dojo.getComputedStyle code path for IE9; fixes #14103 on 1.6 branch !strict