[regression][patch][cla] dojox.gfx.svg.Rect setShape no longer checks if this.shape.r has a valid value

[ben hockey]

previously in dojox.gfx.svg.Rect, setShape had some code like this:

if (this.shape.r) {
  this.rawNode.setAttribute("ry", this.shape.r);
  this.rawNode.setAttribute("rx", this.shape.r);
}

now it is:

if ("r" in this.shape) {
  this.rawNode.setAttribute("ry", this.shape.r);
  this.rawNode.setAttribute("rx", this.shape.r);
}

this causes an error if this.shape.r is undefined.

Error: Invalid value for <rect> attribute ry="undefined"
Error: Invalid value for <rect> attribute rx="undefined"

probably a better option would be:

if (this.shape.r != null) {
  this.rawNode.setAttribute("ry", this.shape.r);
  this.rawNode.setAttribute("rx", this.shape.r);
}

NOTE: intentionally using != instead of !== so that null and undefined or rejected but 0 is accepted.

[ben hockey]

In [26881]:

fix regression from r26233. fixes #14100 !strict