Opened 9 years ago
Closed 9 years ago
#14096 closed defect (fixed)
ComboBox causes ScrollableView to scroll down
Reported by: | Paul Christopher | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.8 |
Component: | DojoX Mobile | Version: | 1.7.0b1 |
Keywords: | Cc: | Douglas Hays, Atsushi Ono, ykami | |
Blocked By: | Blocking: |
Description
Description:
A combo box placed into a scrollable view causes - when opened - the view to scroll down. Moreover the selection list is misplaced. There is quite a huge distance between the text box and the selection list (see screenshot before.png and after.png).
Steps to reproduce:
Use the attached test case. Run it on Firefox7. Click into the text box so as to open the selection list of the combo box. This will cause the whole view to scroll down. The selection list is placed quite in some distance to the text box.
Dojo version: dojo-1.7.rc
Browser: Firefox7
Attachments (8)
Change History (16)
Changed 9 years ago by
Attachment: | index.html added |
---|
Changed 9 years ago by
Changed 9 years ago by
Attachment: | Before.PNG added |
---|
comment:1 Changed 9 years ago by
Changed 9 years ago by
Attachment: | index2.html added |
---|
Changed 9 years ago by
Attachment: | after2.png added |
---|
Changed 9 years ago by
Attachment: | before2.png added |
---|
comment:2 Changed 9 years ago by
Cc: | Douglas Hays added |
---|
I confirmed the problem.
Doug, do you know what scrolls the page when ComboBox gets focus?
comment:3 Changed 9 years ago by
Milestone: | 1.7 → 1.7.1 |
---|---|
Owner: | changed from ykami to Douglas Hays |
Status: | new → assigned |
comment:5 Changed 9 years ago by
Cc: | Atsushi Ono ykami added |
---|
Doug, onoat has reviewed and tested the fix.
Onoat, could you explain the test result and your findings if any?
comment:6 Changed 9 years ago by
Doug, I have reviewed and tested the fix on iPhone and Android. It works quite better on both devices, and the code looks good to me.
One little concern is that ScrollableView's scrolling becomes choppy while ComboBox dropdown stays open because the dropdown position is adjusted every 50ms. I think it might be better to close ComboBox dropdown when starting to scroll the ScrollableView (on 'touchstart' event?), but I guess this is closely related to #14124. We'll work on #14124 to enable this.
Changed 9 years ago by
Attachment: | 14096_2.patch added |
---|
updated fix with performance fix while scrolling, requires #14124
comment:7 Changed 9 years ago by
Milestone: | 1.7.1 → 1.8 |
---|
Fix needs more test time before being backported to 1.7 along with #14124.
Added new test case (index2.html, before2.png, after2.png).
This all happens to me with dojo-1.7.rc1 and Firefox 7.0.1.