Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14089 closed defect (fixed)

[patch][cla] dojoReport has hard-coded filename (ignores buildReportDir and buildReportFilename)

Reported by: ben hockey Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

a small oversight, the dojoReport transform has a hard-coded filename for the report and ignores the buildReportDir and buildReportFilename profile properties.

Change History (4)

comment:1 Changed 8 years ago by ben hockey

the fix is simple

  • transforms/dojoReport.js

     
    11define(["../buildControl", "../version", "../fileUtils"], function(bc, version, fileUtils) {
    2        var dir = ".",
    3                filename = "build-report.txt";
     2       var dir = bc.buildReportDir,
     3               filename = bc.buildReportFilename;
    44
    55       return function(resource, callback) {
    66               resource.reports.push({

comment:2 Changed 8 years ago by ben hockey

Summary: dojoReport has hard-coded filename (ignores buildReportDir and buildReportFilename)[patch][cla] dojoReport has hard-coded filename (ignores buildReportDir and buildReportFilename)

comment:3 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [26882]:

added profile parameters buildReportDir and buildReportFilename; fixes #14089; !strict

comment:4 Changed 8 years ago by Adam Peller

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.