Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#14088 closed defect (invalid)

[regression] "mblCSS3Transition:true" in djConfig will Break App Loading

Reported by: Ming Zhe Huang Owned by: ykami
Priority: blocker Milestone: tbd
Component: DojoX Mobile Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Try add "mblCSS3Transition:true" into djConfig. You can try mobileGallery. The app cannot be loaded. After some investigation, I found the following suspicious codes: Code transition.js line 13:

  require([config['mblCSS3Transition']], function(transit){
      transitDeferred.resolve(transit);
  });

If we set "mblCSS3Transition:true" to djConfig, this code will pass in boolean value "True" which will in the end causes error in the following code: Code dojo.js line 895:

  match = mid.match(/^(.+?)\!(.*)$/);

"True" doesn't have "match()" method.

Change History (5)

comment:1 Changed 8 years ago by zhangyp

I think we need to discuss about whether we should do conditional require to pull in dependencies. However, in this case, mblCSS3Tranistion should be set to 'dojox/css3/transit'.

comment:2 Changed 8 years ago by ykami

Resolution: invalid
Status: newclosed

comment:3 Changed 6 years ago by cjolif

In [30452]:

refs #14088. Fix incorrect require path + rename test to better patch Dojo Camel case naming.

comment:4 Changed 6 years ago by cjolif

In [30453]:

refs #14088. Fix test ref. Thanks Sebastien Brunot (IBM, CCLA).

comment:5 Changed 6 years ago by cjolif

In [30454]:

refs #14088. Fix test ref. Thanks Sebastien Brunot (IBM, CCLA).

Note: See TracTickets for help on using tickets.