Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14080 closed defect (fixed)

[CLA][PATCH]dojox/fx/tests/test_scroll.html/test_split.html broken

Reported by: Evan Owned by: Adam Peller
Priority: high Milestone: 1.7
Component: Dojox Version: 1.7.0b1
Keywords: dojox, fx Cc: Chris Mitchell, Bryan Forbes
Blocked By: Blocking:

Description

Seems to be a regression from [26273] - Should use dojo/_base/fx for baseFx.Animation({...}) and baseFx.animateProperty({...})

Attachments (1)

14080.patch (4.7 KB) - added by Evan 8 years ago.
Patch fixed this issue

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Evan

Attachment: 14080.patch added

Patch fixed this issue

comment:1 Changed 8 years ago by bill

Do you need to remove the easeOut parameters? Your patch removes them, but seems like it shouldn't need to.

comment:2 in reply to:  1 Changed 8 years ago by Evan

Replying to bill:

Do you need to remove the easeOut parameters? Your patch removes them, but seems like it shouldn't need to.

Yep, that's necessary, dojo.fx.easing.easeOut is actually 'undefined' and that also broke the test case. BTW, I didn't find the "easeOut" in dojo/fx/easing.js, so seems it's not used.

comment:3 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: newclosed

In [26856]:

AMD fix from Evan, fixes #14080

comment:4 Changed 8 years ago by Adam Peller

Cc: Bryan Forbes added

cc'ing Bryan, in case he knows the intent of the easeOut lines. Perhaps that code was refactored long ago?

comment:5 Changed 8 years ago by Bryan Forbes

I would say that easeOut should be replaced by dojo/fx/easing#sineOut. I believe that's what easeOut used to be aliased to or similar to.

Note: See TracTickets for help on using tickets.