#14080 closed defect (fixed)
[CLA][PATCH]dojox/fx/tests/test_scroll.html/test_split.html broken
| Reported by: | Evan | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | Dojox | Version: | 1.7.0b1 |
| Keywords: | dojox, fx | Cc: | Chris Mitchell, Bryan Forbes |
| Blocked By: | Blocking: |
Description
Seems to be a regression from [26273] - Should use dojo/_base/fx for baseFx.Animation({...}) and baseFx.animateProperty({...})
Attachments (1)
Change History (6)
Changed 8 years ago by
| Attachment: | 14080.patch added |
|---|
comment:1 follow-up: 2 Changed 8 years ago by
Do you need to remove the easeOut parameters? Your patch removes them, but seems like it shouldn't need to.
comment:2 Changed 8 years ago by
Replying to bill:
Do you need to remove the easeOut parameters? Your patch removes them, but seems like it shouldn't need to.
Yep, that's necessary, dojo.fx.easing.easeOut is actually 'undefined' and that also broke the test case. BTW, I didn't find the "easeOut" in dojo/fx/easing.js, so seems it's not used.
comment:4 Changed 8 years ago by
| Cc: | Bryan Forbes added |
|---|
cc'ing Bryan, in case he knows the intent of the easeOut lines. Perhaps that code was refactored long ago?
comment:5 Changed 8 years ago by
I would say that easeOut should be replaced by dojo/fx/easing#sineOut. I believe that's what easeOut used to be aliased to or similar to.
Patch fixed this issue