Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14079 closed defect (fixed)

aria-pressed should not be set on a checkbox

Reported by: Katie Vance Owned by: Douglas Hays
Priority: high Milestone: 1.7.1
Component: Accessibility Version: 1.6.1
Keywords: Cc: Becky Gibson
Blocked By: Blocking:

Description

The ARIA spec requires that aria-pressed should not be set on a checkbox.

Attachments (1)

14079.patch (531 bytes) - added by Katie Vance 8 years ago.
Remove aria-pressed from checkboxes

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by Katie Vance

Attachment: 14079.patch added

Remove aria-pressed from checkboxes

comment:1 Changed 8 years ago by Katie Vance

Attached a patch.

comment:2 Changed 8 years ago by Douglas Hays

Katie, ToggleButton? sets aria-pressed to false. Is removing the attribute more correct? Why add _setCheckedAttr method to CheckBox? when ToggleButton? already has that method and fiddles with aria-pressed?

comment:3 Changed 8 years ago by Douglas Hays

aria-pressed should be changed to aria-checked instead of removed

comment:4 Changed 8 years ago by Douglas Hays

Milestone: tbd1.7.1
Owner: changed from Katie Vance to Douglas Hays
Status: newassigned
Summary: aris-pressed should not be set on a checkboxaria-pressed should not be set on a checkbox

comment:5 Changed 8 years ago by Katie Vance

Also add aria-checked to the checkbox.

comment:6 Changed 8 years ago by Douglas Hays

becky thinks the original removal for checkboxes may be more correct since checkboxes are native input type=checked and thus would be handled correctly by the browser w/o any aria info

comment:7 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [26931]:

Fixes #14079. Change aria-pressed (ToggleButton?) to aria-checked for CheckBoxes? and add automated tests.

comment:8 Changed 8 years ago by Douglas Hays

In [26932]:

Refs #14079. Backport trunk/[26931] to 1.7.1.

comment:9 Changed 8 years ago by bill

Shouldn't there be a change to StackController.js too? It currently has:

_setCheckedAttr: function(/*Boolean*/ value, /*Boolean?*/ priorityChange){
	this.inherited(arguments);
	this.focusNode.removeAttribute("aria-pressed");
},

comment:10 Changed 8 years ago by bill

In [27078]:

More efficient way to get StackController to set aria-selected on correct StackButton, refs #14079 !strict.

Note: See TracTickets for help on using tickets.