Opened 8 years ago

Closed 8 years ago

#14064 closed defect (fixed)

CLDR data regression on 1.7

Reported by: mikeb Owned by: Adam Peller
Priority: high Milestone: 1.7
Component: Internationalization Version: 1.7.0b1
Keywords: Cc: Ed Chatelain, Evan, cjolif
Blocked By: Blocking:

Description

The Islamic calendar seems to prevent the usage of the correct resource bundle for this calendar (dojo/cldr/nls/ar/islamic.js).

Move the attached sample in dojox/date/tests and launch it.

The application is in 'ar' locale.

The left most calendar widget is using the Gregorian calendar and is displaying the month names using Arabic characters. The right most calendar widget is using the Islamic calendar and is _not_ displaying month names using Arabic characters.

Seems to be a CLDR problem as determined by the console output of dojo.i18n.getLocalization("dojo.cldr", "islamic"); in 1.7 vs 1.6

Attachments (3)

14064_Calendar_ar.html (1.5 KB) - added by mikeb 8 years ago.
CLDR data test case
14064.patch (2.5 KB) - added by Evan 8 years ago.
Fixes util/buildscripts/cldr/alias.js to process un-gregorian bundles appropriately
cldrUtil.patch (467 bytes) - added by Adam Peller 8 years ago.
monkey-patch dojo.xhrGet

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by mikeb

Attachment: 14064_Calendar_ar.html added

CLDR data test case

comment:1 Changed 8 years ago by Adam Peller

the problem can be reduced to just looking at the generated file at dojo/cldr/nls/ar/islamic.js -- it matches what's in the CLDR XML, but somehow we had logic which copied over the missing data from the Gregorian calendar (e.g. days of the week, which are the same, also "standalone" vs. "format") and that's no longer working. Evan, do you remember where this happens (in the XSLT?) and do you have any idea what might have gone wrong?

Last edited 8 years ago by Adam Peller (previous) (diff)

comment:2 Changed 8 years ago by cjolif

Cc: cjolif added

Changed 8 years ago by Evan

Attachment: 14064.patch added

Fixes util/buildscripts/cldr/alias.js to process un-gregorian bundles appropriately

comment:3 Changed 8 years ago by Adam Peller

Milestone: tbd1.7.1

Changed 8 years ago by Adam Peller

Attachment: cldrUtil.patch added

monkey-patch dojo.xhrGet

comment:4 Changed 8 years ago by Adam Peller

simple patch for xhr provided. Evan notes that dojo.i18n.getLocalizations is failing on Rhino (#14093) Evan, getLocalizations is used in specialLocale and arrayInherit too, not just alias... could this be causing more problems?

Last edited 8 years ago by Adam Peller (previous) (diff)

comment:5 Changed 8 years ago by Adam Peller

Milestone: 1.7.11.7
Priority: normalhigh

moving for consideration in rc2

comment:6 Changed 8 years ago by Adam Peller

In [26883]:

Refs #14064 Monkey patch to provide dojo.xhr impl for Rhino, proper processing for non-gregorian calendar resources

comment:7 Changed 8 years ago by Adam Peller

Resolution: fixed
Status: newclosed

In [26884]:

Fixes #14064 Regenerate dojo.cldr bundles
Fixes #14064 Regenerate dojo.cldr bundlesThis line, and those below, will be ignored--

M nls/da/buddhist.js
M nls/da/gregorian.js
M nls/da/islamic.js
M nls/de/buddhist.js
M nls/de/gregorian.js
M nls/de/islamic.js
M nls/sv/gregorian.js
M nls/ja/gregorian.js
M nls/he/hebrew.js
M nls/he/gregorian.js
M nls/he/islamic.js
M nls/fi/buddhist.js
M nls/fi/hebrew.js
M nls/fi/gregorian.js
M nls/fi/islamic.js
M nls/nb/gregorian.js
M nls/fr/gregorian.js
M nls/nl/gregorian.js
M nls/pl/gregorian.js
M nls/th/buddhist.js
M nls/th/gregorian.js
M nls/hu/gregorian.js
M nls/ro/buddhist.js
M nls/ro/gregorian.js
M nls/zh/gregorian.js
M nls/zh-hk/number.js
M nls/zh-hk/currency.js
M nls/zh-hk/gregorian.js
M nls/ca/gregorian.js
M nls/pt/gregorian.js
M nls/tr/gregorian.js
M nls/ru/gregorian.js
M nls/en-gb/buddhist.js
M nls/en-gb/islamic.js
M nls/el/buddhist.js
M nls/el/hebrew.js
M nls/el/gregorian.js
M nls/ar/buddhist.js
M nls/ar/hebrew.js
M nls/ar/gregorian.js
M nls/ar/islamic.js
M nls/en/buddhist.js
M nls/en/gregorian.js
M nls/en/islamic.js
M nls/pt-pt/gregorian.js
M nls/cs/gregorian.js
M nls/es/buddhist.js
M nls/es/gregorian.js
M nls/es/islamic.js
M nls/zh-tw/currency.js
M nls/zh-tw/gregorian.js
M nls/ko/gregorian.js
M nls/zh-hant/buddhist.js
M nls/zh-hant/gregorian.js
M nls/zh-hant/islamic.js
M nls/it/gregorian.js
M nls/sk/gregorian.js
M nls/sl/gregorian.js

Note: See TracTickets for help on using tickets.