Opened 8 years ago

Closed 8 years ago

#14060 closed defect (fixed)

dojox.charting.widget.Legend refresh doesn't update labels

Reported by: kiuma Owned by: cjolif
Priority: low Milestone: 1.8
Component: Charting Version: 1.6.1
Keywords: dojox.charting.widget.Legend Cc: cjolif
Blocked By: Blocking:

Description

Legend.series is an array, so when the referring chart updates series, Legend doesn't update its labels.

To correct this simply change:

this.series = this.chart.chart.series; into this.series = function() {return this.chart.chart.series};

this.series = this.chart.series; into this.series = function() {return this.chart.series};

and finally var s = this.series; into var s = this.series();

the defect is present both in v 1.6.1 and 1.7xxx

cheers, kiuma

Change History (6)

comment:1 Changed 8 years ago by cjolif

Cc: cjolif added
Owner: changed from Eugene Lazutkin to cjolif
Status: newassigned

Another issue is with SelectableLegend that works with chart gfx shapes that are not updated in the legend when the chart itself is re-rendered and thus that gfx shapes changed. Workaround for that second problem is to call refresh() explicitly on the Legend.

Last edited 8 years ago by cjolif (previous) (diff)

comment:2 Changed 8 years ago by cjolif

severity: blockermajor

This does not look to me as a blocker a workaround is to call yourself mylegend.series = mychar.series before refreshing it. Of course that is not nice and we should fix it but that is not a blocker. Except if you tell me that workaround does not work?

comment:3 Changed 8 years ago by kiuma

ok, it's well with severity: major.

@cjolf of course this affects SelectableLegend too (the one I'm currently using) but bug comes from its parent class :)

kiuma

Last edited 8 years ago by cjolif (previous) (diff)

comment:4 Changed 8 years ago by Colin Snover

Priority: highblocker

Bulk update of open ticket priorities.

comment:5 Changed 8 years ago by cjolif

Milestone: tbd1.8
Priority: blockerlow

This is certainly not a blocker as there is a workaround.

comment:6 Changed 8 years ago by cjolif

Resolution: fixed
Status: assignedclosed

In [27687]:

fixes #14060.

Note: See TracTickets for help on using tickets.