Opened 9 years ago
Closed 9 years ago
#14033 closed defect (fixed)
fix unguarded references to dojo, dijit and dojox globals
Reported by: | ben hockey | Owned by: | ben hockey |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | General | Version: | 1.7.0b1 |
Keywords: | Cc: | Jared Jurkiewicz | |
Blocked By: | Blocking: |
Change History (22)
comment:1 Changed 9 years ago by
comment:13 Changed 9 years ago by
there are still a number of unguarded references in dojox but i'll leave those for anyone else who has the time to find them. searching for getObject
and looking for usage like getObject('some.module', true, dojox);
is a good way to start finding these references.
comment:14 Changed 9 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
found more issues in dijit/Tooltip (dijit.shotTooltip
and dijit.hideTooltip
) - reopening ticket to fix these and look for more.
comment:15 Changed 9 years ago by
Keywords: | jaredj added |
---|
jared,
dijit/_editor/RichText, dijit/_editor/plugins/EnterKeyHandling have a number of references to dojo.global
that should probably be kernel.global
. i don't want to break the code so i haven't touched these but they should be changed to avoid referencing dojo
as a global when it might not exist.
comment:17 Changed 9 years ago by
Those editor references were misspelled as "gobal" rather than "global", yet the editor was still working. That's why I didn't change them. (They should be updated at some point, either to kernel.global or null or ...)
comment:20 Changed 9 years ago by
Cc: | Jared Jurkiewicz added |
---|---|
Keywords: | jaredj removed |
I talked to Jared about the Editor; I'll check in those fixes.
comment:22 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
that seems like enough to close this ticket. any remaining occurrences in dojox can be fixed as they're found.
this should only block an RC - not a blocker for a beta release.