fix unguarded references to dojo, dijit and dojox globals

[ben hockey]

there are a number of places where globals are referenced without checking for their existence. see #13603, #14030 and r26745.

this ticket is to track changes related to fixing this.

[ben hockey]

this should only block an RC - not a blocker for a beta release.

[ben hockey]

In [26751]:

fix unguarde reference to globals. refs #14033. !strict

[ben hockey]

In [26752]:

fix unguarde reference to globals. refs #14033. !strict

[ben hockey]

In [26753]:

fix unguarded reference to globals. refs #14033. !strict

[ben hockey]

In [26754]:

fix unguarded reference to globals. refs #14033. !strict

[ben hockey]

In [26755]:

fix unguarded reference to globals. refs #14033. !strict

[ben hockey]

In [26756]:

fix unguarded reference to globals. refs #14033. !strict

[ben hockey]

In [26757]:

remove unneeded comment. refs #14033. !strict

[ben hockey]

In [26758]:

use relative module ids. refs #14033. !strict

[ben hockey]

In [26759]:

fix unguarded reference to globals. refs #14033. !strict

[ben hockey]

In [26760]:

fix unguarded reference to globals and fix bug in dojox.collections.Iterator. refs #14033. !strict

[ben hockey]

In [26761]:

fix unguarded reference to globals. fixes #14033. !strict

[ben hockey]

there are still a number of unguarded references in dojox but i'll leave those for anyone else who has the time to find them. searching for getObject and looking for usage like getObject('some.module', true, dojox); is a good way to start finding these references.

[ben hockey]

found more issues in dijit/Tooltip (dijit.shotTooltip and dijit.hideTooltip) - reopening ticket to fix these and look for more.

[ben hockey]

jared,

dijit/_editor/RichText, dijit/_editor/plugins/EnterKeyHandling have a number of references to dojo.global that should probably be kernel.global. i don't want to break the code so i haven't touched these but they should be changed to avoid referencing dojo as a global when it might not exist.

[ben hockey]

In [26780]:

fix global references to dijit and dojo. refs #14033

[bill]

Those editor references were misspelled as "gobal" rather than "global", yet the editor was still working. That's why I didn't change them. (They should be updated at some point, either to kernel.global or null or ...)

[Chris Mitchell]

In [26788]:

refs #14033 - cleanup references in dojox/encoding \!strict

[Chris Mitchell]

In [26790]:

refs #14033 - cleanup references in dojox/validate \!strict

[bill]

I talked to Jared about the Editor; I'll check in those fixes.

[bill]

In [26812]:

Editor doesn't need to pass a window (a.k.a. dojo.global) argument to rangeapi.create() since there's already a surrounding withGlobal() block. I'd like to get rid of the surrounding withGlobal() block but it's (currently) also needed for the dijit._editor.selection.collapse() calls. Refs #14033 !strict, resolving global dojo references in editor.

[ben hockey]

that seems like enough to close this ticket. any remaining occurrences in dojox can be fixed as they're found.