Opened 8 years ago

Closed 8 years ago

#14033 closed defect (fixed)

fix unguarded references to dojo, dijit and dojox globals

Reported by: ben hockey Owned by: ben hockey
Priority: high Milestone: 1.7
Component: General Version: 1.7.0b1
Keywords: Cc: Jared Jurkiewicz
Blocked By: Blocking:

Description

there are a number of places where globals are referenced without checking for their existence. see #13603, #14030 and r26745.

this ticket is to track changes related to fixing this.

Change History (22)

comment:1 Changed 8 years ago by ben hockey

this should only block an RC - not a blocker for a beta release.

comment:2 Changed 8 years ago by ben hockey

In [26751]:

fix unguarde reference to globals. refs #14033. !strict

comment:3 Changed 8 years ago by ben hockey

In [26752]:

fix unguarde reference to globals. refs #14033. !strict

comment:4 Changed 8 years ago by ben hockey

In [26753]:

fix unguarded reference to globals. refs #14033. !strict

comment:5 Changed 8 years ago by ben hockey

In [26754]:

fix unguarded reference to globals. refs #14033. !strict

comment:6 Changed 8 years ago by ben hockey

In [26755]:

fix unguarded reference to globals. refs #14033. !strict

comment:7 Changed 8 years ago by ben hockey

In [26756]:

fix unguarded reference to globals. refs #14033. !strict

comment:8 Changed 8 years ago by ben hockey

In [26757]:

remove unneeded comment. refs #14033. !strict

comment:9 Changed 8 years ago by ben hockey

In [26758]:

use relative module ids. refs #14033. !strict

comment:10 Changed 8 years ago by ben hockey

In [26759]:

fix unguarded reference to globals. refs #14033. !strict

comment:11 Changed 8 years ago by ben hockey

In [26760]:

fix unguarded reference to globals and fix bug in dojox.collections.Iterator. refs #14033. !strict

comment:12 Changed 8 years ago by ben hockey

Resolution: fixed
Status: newclosed

In [26761]:

fix unguarded reference to globals. fixes #14033. !strict

comment:13 Changed 8 years ago by ben hockey

there are still a number of unguarded references in dojox but i'll leave those for anyone else who has the time to find them. searching for getObject and looking for usage like getObject('some.module', true, dojox); is a good way to start finding these references.

comment:14 Changed 8 years ago by ben hockey

Resolution: fixed
Status: closedreopened

found more issues in dijit/Tooltip (dijit.shotTooltip and dijit.hideTooltip) - reopening ticket to fix these and look for more.

comment:15 Changed 8 years ago by ben hockey

Keywords: jaredj added

jared,

dijit/_editor/RichText, dijit/_editor/plugins/EnterKeyHandling have a number of references to dojo.global that should probably be kernel.global. i don't want to break the code so i haven't touched these but they should be changed to avoid referencing dojo as a global when it might not exist.

comment:16 Changed 8 years ago by ben hockey

In [26780]:

fix global references to dijit and dojo. refs #14033

comment:17 Changed 8 years ago by bill

Those editor references were misspelled as "gobal" rather than "global", yet the editor was still working. That's why I didn't change them. (They should be updated at some point, either to kernel.global or null or ...)

Last edited 8 years ago by bill (previous) (diff)

comment:18 Changed 8 years ago by Chris Mitchell

In [26788]:

refs #14033 - cleanup references in dojox/encoding \!strict

comment:19 Changed 8 years ago by Chris Mitchell

In [26790]:

refs #14033 - cleanup references in dojox/validate \!strict

comment:20 Changed 8 years ago by bill

Cc: Jared Jurkiewicz added
Keywords: jaredj removed

I talked to Jared about the Editor; I'll check in those fixes.

comment:21 Changed 8 years ago by bill

In [26812]:

Editor doesn't need to pass a window (a.k.a. dojo.global) argument to rangeapi.create() since there's already a surrounding withGlobal() block. I'd like to get rid of the surrounding withGlobal() block but it's (currently) also needed for the dijit._editor.selection.collapse() calls. Refs #14033 !strict, resolving global dojo references in editor.

comment:22 Changed 8 years ago by ben hockey

Resolution: fixed
Status: reopenedclosed

that seems like enough to close this ticket. any remaining occurrences in dojox can be fixed as they're found.

Note: See TracTickets for help on using tickets.