Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14031 closed defect (fixed)

using closure optimizer can produce an empty dojo.js

Reported by: ben hockey Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Loader Version: 1.7.0b1
Keywords: Cc: Chris Mitchell
Blocked By: Blocking:

Description

simply run this command and check the built version of dojo.js

./build.sh -p base --release --layerOptimize closure

Change History (6)

comment:1 Changed 8 years ago by ben hockey

btw, the reason i marked this as major severity is because to take advantage of the dead branch removal you must use the closure compiler.

comment:2 Changed 8 years ago by Chris Mitchell

Priority: normalhigh

setting priority high, to get this on the hot list.

comment:3 Changed 8 years ago by Chris Mitchell

Cc: Chris Mitchell added

comment:4 Changed 8 years ago by Chris Mitchell

Milestone: tbd1.7

comment:5 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [26739]:

fixed typo in dojo/topic; added feature to report if optimizer finds errors to console; fixes #14031; !strict

comment:6 Changed 8 years ago by Rawld Gill

dojo/topic contained a typo (a syntax error) that choked the closure compiler. This was reported in the build report; however there was no hint given in the console output of the build. Added build feature to report to console output when optimizer finds errors.

Note: See TracTickets for help on using tickets.