Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14025 closed defect (fixed)

dojox.html.metrics.getScrollbar() returns default values (w:16, h:16)

Reported by: dg Owned by: Bryan Forbes
Priority: high Milestone: 1.7
Component: Dojox Version: 1.7.0b1
Keywords: Cc: chrism1, cjolif
Blocked By: Blocking:

Description

dojox.html.metrics.getScrollbar() returns default values (w:16, h:16).[[BR]]

It seems that the computed result (usually w:17 in FF7/win) is overridden by default value. Maybe related to AMD?

See attached reproducing sample.

Attachments (2)

ScrollbarMetricsIssues.html (843 bytes) - added by dg 8 years ago.
dojox.html.metrics.patch (842 bytes) - added by cjolif 8 years ago.
patch

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by dg

Attachment: ScrollbarMetricsIssues.html added

comment:1 Changed 8 years ago by Adam Peller

Cc: chrism1 added
Owner: changed from Adam Peller to Bryan Forbes

comment:2 Changed 8 years ago by cjolif

Cc: cjolif added

comment:3 Changed 8 years ago by cjolif

Version: 1.7.0b1

This is indeed a regression introduced by AMD. I'm preparing a patch.

Changed 8 years ago by cjolif

Attachment: dojox.html.metrics.patch added

patch

comment:4 Changed 8 years ago by cjolif

The problem came from a change from dojo.addOnLoad to UnloadUtil.addOn_Un_load during AMD transition. The patch is fixing this. If nobody objects and dg confirms it solves his issue I can commit it.

Last edited 8 years ago by cjolif (previous) (diff)

comment:5 Changed 8 years ago by dg

Hi, I confirm that the patch proposed by cjolif is indeed fixing the issue. Thanks,

comment:6 Changed 8 years ago by cjolif

Resolution: fixed
Status: newclosed

In [26803]:

fixes regression introduce by AMD transition. fixes #14025.

comment:7 Changed 8 years ago by cjolif

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.