Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14024 closed enhancement (fixed)

Converting dojox.NodeList.delegate to AMD format

Reported by: tomc974 Owned by: bill
Priority: high Milestone: 1.7
Component: Dojox Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

I didn't notice at first that ticket #12863 was closed... Anyway, I've attached to it a patch to convert dojox.NodeList?.delegate to AMD format. The patch also includes a test for async mode.

Change History (6)

comment:1 Changed 8 years ago by Adam Peller

Owner: changed from Adam Peller to bill

comment:2 Changed 8 years ago by bill

Resolution: → fixed
Status: new → closed

In [26741]:

Convert !Nodelist.delegate to AMD format, patch from tomc974 (CLA), fixes #14024 !strict. Note though that NodeList.delegate() has been replaced by functionality in dojo/on.

comment:3 Changed 8 years ago by bill

Milestone: tbd → 1.7

Thanks for the patch, note though that NodeList.delegate() has been replaced by functionality in dojo/on.

Last edited 8 years ago by bill (previous) (diff)

comment:4 Changed 8 years ago by tomc974

I know dojo/on can replace NodeList?.delegate() but I came across this module while playing with the API Documentation Previewer which I'm currently rewriting to support documentation written with non-ASCII characters. So I converted it.

comment:5 Changed 8 years ago by bill

OK, thanks.

comment:6 Changed 8 years ago by ben hockey

In [26749]:

mark dojox/Nodelist as AMD for the builder. refs #14024

Note: See TracTickets for help on using tickets.