Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14014 closed enhancement (fixed)

only create Tooltip._masterTT when showing (not when hiding)

Reported by: ben hockey Owned by: ben hockey
Priority: high Milestone: 1.7
Component: Dijit Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

dijit.hideTooltip creates a Tooltip._masterTT if none exists. this seems unnecessary.

Change History (2)

comment:1 Changed 8 years ago by ben hockey

Resolution: fixed
Status: newclosed

In [26711]:

don't create Tooltip._masterTT when hiding. fixes #14014. !strict

comment:2 Changed 8 years ago by bill

Re your comment on IRC:

r26711 seems to have caused some problems with the Tooltip-placement test. it looks like it just made an existing intermittent problem happen more often. tests timeout and i think widget.focusNode.focus() might need a setTimeout - not sure, but that seemed to help the test pass more consistently.

do you want me to revert that change? comment on #14014 if i'm not here

Sounds like we should just update that test. That test has been problematic from the beginning. If you have an update to make the test work better please check it in.

Note: See TracTickets for help on using tickets.