Opened 8 years ago

Closed 8 years ago

#14006 closed defect (fixed)

Buddhist, Hebrew and Islamic calendar difference method result is inconsistent with Gregorian calendar one

Reported by: Katie Vance Owned by: Adam Peller
Priority: high Milestone: 1.7
Component: Dojox Version: 1.6.1
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

The difference() method of Buddhist, Hebrew and Islamic calendar is returning a result whose sign (+/-) is inverted with respect to Gregorian Calendar one. To be consistent, the parameter order should be the same.

Attachments (1)

14006.patch​ (21.0 KB) - added by Katie Vance 8 years ago.
Switch order of date1 and date2 parameters to be consistent with dojo.date

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Katie Vance

Attachment: 14006.patch​ added

Switch order of date1 and date2 parameters to be consistent with dojo.date

comment:1 Changed 8 years ago by Katie Vance

Added patch to switch the order.

comment:2 Changed 8 years ago by cjolif

Cc: cjolif added

comment:3 Changed 8 years ago by Adam Peller

Milestone: tbd → 1.7
Owner: changed from Katie Vance to Adam Peller
Status: new → assigned

comment:4 Changed 8 years ago by Adam Peller

Resolution: → fixed
Status: assigned → closed

In [26699]:

Use proper subtraction in difference. Fixes #14006. Thanks, ksv

Note: See TracTickets for help on using tickets.