Opened 8 years ago

Closed 8 years ago

#13999 closed enhancement (fixed)

Default version # in dev trunk build scripts

Reported by: dylan Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: BuildSystem Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Currently, in builds from trunk (and perhaps other places), the default version for a custom build, if not specified, is 0.0.0. Most users do not set this.

In helping users, or in determining what version various users are using, it would be nice if we preset this for them.

This is something we could retrieve from a metadata file that we'd need to keep updated in various branches, etc., but I think it's worthwhile to give our users better default values.

Change History (4)

comment:1 Changed 8 years ago by dylan

P.S. I also think it's very important for the use case of Dojo Foundation packages, which need to define dependencies. Custom builds with version numbers that aren't real will break, so perhaps we need to have an internal and user version number (some users specify a version that coincides with their own release cycle, etc.)

comment:2 Changed 8 years ago by ben hockey

i see 2 places you could already pull this from without introducing another metadata file.

  • since the build is actually run by a version of dojo (which will have a version number), you could default to that version number if none was provided
  • use the version number from dojo's package.json

fwiw, i have always exploited dojo's built version number for my own use. currently, i leave the major, minor and patch segments to match the version of dojo (eg 1.7.0) and then i use flag for my own needs (typically <timestamp of the build>-<dojo revision number>, eg "1316704847000-r26636"). unfortunately, the revision flag of dojo.version can't be set when doing a build but that's not a big deal.

going to follow this ticket to make sure i can still manage to exploit the version number (or an alternative) for fun and/or profit as needed :)

comment:3 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [26710]:

added feature to stamp build with dojo package version if no explicit version given; fixes #13999; !strict

comment:4 Changed 8 years ago by bill

Milestone: tbd1.7
Note: See TracTickets for help on using tickets.