Opened 7 years ago

Closed 7 years ago

#13994 closed defect (fixed)

Tree: replace stopEvent with preventDefault in tree._dndSelector.onMouseDown

Reported by: Simon Speich Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version:
Keywords: tree, drag and drop, dnd Cc:
Blocked By: Blocking:

Description

dijit.tree._dndSelector.onMouseDown() calls event.stop(e) on line 185 to prevent the browser from selecting text when the user drags. But this prevents using the event mouseDown higher up in the DOM hierarchy and should therefore be replaced with e.preventDefault() instead, which prevents the selecting, but does not cancel the bubbling up.

Change History (2)

comment:1 Changed 7 years ago by bill

Milestone: tbd → 1.7
Owner: set to bill
Status: new → assigned
Summary: Replace stopEvent with preventDefault in tree._dndSelector.onMouseDown → Tree: replace stopEvent with preventDefault in tree._dndSelector.onMouseDown

comment:2 Changed 7 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [26668]:

Use evt.preventDefault() rather than event.stopEvent(evt) so that mousedown can still propagate to ancestor nodes. Fixes #13994 !strict.

Note: See TracTickets for help on using tickets.