#13993 closed defect (fixed)
[regression] themeTester no longer honors theme, dir, etc. query params
Reported by: | Kenneth G. Franqueiro | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Dijit | Version: | 1.7.0b1 |
Keywords: | Cc: | Douglas Hays | |
Blocked By: | Blocking: |
Description
dijit/themes/themeTester.html in trunk doesn't honor the theme and dir (and presumably other) query params, which are quite important and useful in the context of this page.
The reason would appear to be that dijit/tests/_testCommon.js is no longer loaded. In 1.6, this was loaded via a normal script tag. It would appear that in trunk, it was attempted to be loaded as a module (and indeed looks to be one), but is currently commented out. (I'd point out that its commenting predates the latest revision of that line.)
Upon uncommenting that line, themeTester still appears to work under normal (param-less) circumstances, as well as with dir=rtl. However, specifying a theme (even redundantly specifying claro) results in nothing but a blank page.
Change History (9)
comment:1 Changed 9 years ago by
Component: | General → Dijit |
---|
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
Upon a bit more investigation, reverting the last change to _testCommon.js ([26353]) seems to make theme switching on other test pages work again, but it still doesn't resolve the issue in themeTester.
Now I'm not sure if I've actually found two separate issues, or what...
comment:4 Changed 9 years ago by
Cc: | Douglas Hays added |
---|
comment:7 Changed 9 years ago by
Owner: | set to bill |
---|---|
Resolution: | → fixed |
Status: | new → closed |
In [26694]:
It would appear there may actually be an error *in* _testCommon.js actually... Although I don't see any errors reported when I try to include it in themeTester.html, if I go to other test pages that use it (e.g.
dijit/tests/test_Calendar.html
,dijit/tests/test_Toolbar.html
, ...) if I add?theme=...
to the URL, I end up with the following error:loadFuncs[i] is not a function (_testCommon.js:123)