Opened 8 years ago
Closed 8 years ago
#13990 closed defect (fixed)
dojox date add methods do not work correctly
| Reported by: | Katie Vance | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | high | Milestone: | 1.7 |
| Component: | Dojox | Version: | 1.6.1 |
| Keywords: | Cc: | cjolif | |
| Blocked By: | Blocking: |
Description
For Hebrew, Islamic, and Buddhist dates, adding milliseconds does not work correctly. See attached test cases to compare those dates to the Gregorian dates.
Attachments (6)
Change History (18)
Changed 8 years ago by
| Attachment: | iscCal.html added |
|---|
Changed 8 years ago by
| Attachment: | hebCal.html added |
|---|
Changed 8 years ago by
| Attachment: | budCal.html added |
|---|
Changed 8 years ago by
| Attachment: | 13990.patch added |
|---|
comment:1 Changed 8 years ago by
| Owner: | Katie Vance deleted |
|---|
comment:2 Changed 8 years ago by
| Owner: | set to Katie Vance |
|---|
comment:3 Changed 8 years ago by
In the attached patch, I modified the set methods such that they set only the specified units. Previously it would set the unit and then add to other units if the unit was larger then its allowed size (ie, mins larger than 60). Then instead of using the set methods to add the time, instead I created add methods which will handle adding as a separate function.
comment:4 Changed 8 years ago by
| Cc: | cjolif added |
|---|
comment:5 Changed 8 years ago by
| Owner: | changed from Katie Vance to Adam Peller |
|---|
comment:6 Changed 8 years ago by
| Milestone: | tbd → 1.7 |
|---|
comment:7 Changed 8 years ago by
ideally, the add* methods would be hidden or private. The APIs are generally intended to mimic the JS Date object.
comment:10 Changed 8 years ago by
Katie, sorry, there was a collision. Could you update the patch to trunk?
Changed 8 years ago by
| Attachment: | 13990.3.patch added |
|---|
Modify set methods to work accordingly