Issue in calculation of default page height

[iseeyou]

The defualt page height is calculated at "dojox.grid._Scroller" at function init:

this.defaultPageHeight = this.defaultRowHeight * this.rowsPerPage;

But it ignore situation when user set rowHeight at param of grid. So, i think that right way is

this.defaultPageHeight = (this.grid.rowHeight

this.defaultRowHeight) * this.rowsPerPage;

[Sébastien Le Ray]

This shouldn't affect the rendering but will indeed trigger unneeded page size adjustements.

[Evan]

Refs #13181 - rowHeight is not working well.

[Sébastien Le Ray]

This is not really a duplicate since this is not a defect per see, changing defaultPageHeight computation to

this.defaultPageHeight = (this.grid.rowHeight ? this.grid.rowHeight : this.defaultRowHeight) * this.rowsPerPage;

avoid systematic recomputation of pageHeight

[Evan]

Replying to beuss:

This is not really a duplicate since this is not a defect per see, changing defaultPageHeight computation to

this.defaultPageHeight = (this.grid.rowHeight ? this.grid.rowHeight : this.defaultRowHeight) * this.rowsPerPage;

avoid systematic recomputation of pageHeight

Though not affect rendering, this definitely needs to be addressed once #13181 is fixed.

[Evan]

In [29696]:

Fixes #13983, honor this.grid.rowHeight when initing this.defaultPageHeight

[Evan]

In [29698]:

Refs #13983, also back port to 1.8.x branch