#13983 closed defect (fixed)
Issue in calculation of default page height
Reported by: | iseeyou | Owned by: | Evan |
---|---|---|---|
Priority: | high | Milestone: | 1.8.1 |
Component: | DojoX Grid | Version: | 1.6.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The defualt page height is calculated at "dojox.grid._Scroller" at function init:
this.defaultPageHeight = this.defaultRowHeight * this.rowsPerPage;
But it ignore situation when user set rowHeight at param of grid. So, i think that right way is
this.defaultRowHeight) * this.rowsPerPage; |
Change History (8)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Refs #13181 - rowHeight is not working well.
comment:3 follow-up: 5 Changed 9 years ago by
This is not really a duplicate since this is not a defect per see, changing defaultPageHeight computation to
this.defaultPageHeight = (this.grid.rowHeight ? this.grid.rowHeight : this.defaultRowHeight) * this.rowsPerPage;
avoid systematic recomputation of pageHeight
comment:4 Changed 9 years ago by
Resolution: | duplicate |
---|---|
Status: | closed → reopened |
comment:5 Changed 9 years ago by
Replying to beuss:
This is not really a duplicate since this is not a defect per see, changing defaultPageHeight computation to
this.defaultPageHeight = (this.grid.rowHeight ? this.grid.rowHeight : this.defaultRowHeight) * this.rowsPerPage;avoid systematic recomputation of pageHeight
Though not affect rendering, this definitely needs to be addressed once #13181 is fixed.
comment:8 Changed 9 years ago by
Milestone: | tbd → 1.8.1 |
---|
Note: See
TracTickets for help on using
tickets.
This shouldn't affect the rendering but will indeed trigger unneeded page size adjustements.