Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#13983 closed defect (fixed)

Issue in calculation of default page height

Reported by: iseeyou Owned by: Evan
Priority: high Milestone: 1.8.1
Component: DojoX Grid Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

The defualt page height is calculated at "dojox.grid._Scroller" at function init:

this.defaultPageHeight = this.defaultRowHeight * this.rowsPerPage;

But it ignore situation when user set rowHeight at param of grid. So, i think that right way is

this.defaultPageHeight = (this.grid.rowHeight
this.defaultRowHeight) * this.rowsPerPage;

Change History (8)

comment:1 Changed 7 years ago by Sébastien Le Ray

This shouldn't affect the rendering but will indeed trigger unneeded page size adjustements.

comment:2 Changed 7 years ago by Evan

Resolution: duplicate
Status: newclosed

Refs #13181 - rowHeight is not working well.

Last edited 7 years ago by Evan (previous) (diff)

comment:3 Changed 7 years ago by Sébastien Le Ray

This is not really a duplicate since this is not a defect per see, changing defaultPageHeight computation to

this.defaultPageHeight = (this.grid.rowHeight ? this.grid.rowHeight : this.defaultRowHeight) * this.rowsPerPage;

avoid systematic recomputation of pageHeight

comment:4 Changed 7 years ago by Evan

Resolution: duplicate
Status: closedreopened

comment:5 in reply to:  3 Changed 7 years ago by Evan

Replying to beuss:

This is not really a duplicate since this is not a defect per see, changing defaultPageHeight computation to

this.defaultPageHeight = (this.grid.rowHeight ? this.grid.rowHeight : this.defaultRowHeight) * this.rowsPerPage;

avoid systematic recomputation of pageHeight

Though not affect rendering, this definitely needs to be addressed once #13181 is fixed.

comment:6 Changed 7 years ago by Evan

Resolution: fixed
Status: reopenedclosed

In [29696]:

Fixes #13983, honor this.grid.rowHeight when initing this.defaultPageHeight

comment:7 Changed 7 years ago by Evan

In [29698]:

Refs #13983, also back port to 1.8.x branch

comment:8 Changed 7 years ago by Evan

Milestone: tbd1.8.1
Note: See TracTickets for help on using tickets.