Opened 10 years ago

Closed 10 years ago

#13978 closed enhancement (fixed)

move _destroyOnRemove property public and document in dojox.grid

Reported by: Karl Tiedt Owned by: Evan
Priority: high Milestone: 1.7
Component: DojoX Grid Version: 1.6.1
Keywords: dojox.grid, formatter, cell widget, cells Cc:
Blocked By: Blocking:


Recently a co-worker stumbled across the code in _View.js that checks cell contents for widgets containing this property "_destroyOnRemove" and destroys this...

This feature which is undocumented, appears to only exist to support dojox.grid.cell.* widgets for Editable cell types...

W/O knowledge of this code, users are forced to jump through hoops to try and avoid huge memory leaks if regular widgets are inserted using formatters... making this more publicly accessible and known would greatly enhance the UX of this portion of grids.

I would like to propose that this property be documented as a feature of the Cell Formatter code and possibly given a non private name and that the destroy routine actually be changed to destroyRecursive() vs destroy()

Change History (1)

comment:1 Changed 10 years ago by Evan

Milestone: tbd1.7
Resolution: fixed
Status: newclosed

Yep, I also didn't realize this attribute until started fixing #13961

But moving it to public may break some existed users, anywhy, I added this info to the doc page.

Note: See TracTickets for help on using tickets.