Opened 9 years ago

Closed 9 years ago

#13977 closed defect (fixed)

.dijitTooltipContainer css does not set color of text in claro theme

Reported by: ben hockey Owned by: bill
Priority: high Milestone: 1.7
Component: themes Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

dijit.css sets the color for .dijitTooltipContainer as color: black;. the claro theme simply inherits this color from dijit.css rather than using the value from the theme (as set by @text-color in variables.less). this produces inconsistencies when trying to build a new theme based on new values in variables.less

the simple fix would be to add something like color: @text-color; to the .claro .dijitTooltipContainer rule in Dialog.less

Change History (3)

comment:1 Changed 9 years ago by bill

Turns out there are a lot of widgets that don't follow @text-color, like Menu, Tree, Calendar, Dialog, etc. I wonder if I should be adding settings for everything (and if so, for Dialog whether it should control the Dialog title and/or the Dialog contents), or if color should just be inherited from <body>. It seems like dijit.css shouldn't have any color settings.

Last edited 9 years ago by bill (previous) (diff)

comment:2 Changed 9 years ago by bill

Milestone: tbd → 1.7

comment:3 Changed 9 years ago by bill

Resolution: → fixed
Status: new → closed

In [26666]:

Make buttons, Calendar, Dialog, Menu, Slider, Textarea, TitlePane, and Tree obey @text-color setting in variables.less. @text-color intentionally doesn't control the content of ContentPane, Dialog, or TitlePanes, but it does control the Dialog's and TitlePane's title, and also Tooltip content. Hopefully that's the right split.

Also tried to get @disabled-text-color working for disabled Textarea/TextBox but IE seems to ignore the setting and make the text gray no matter what.

Fixes #13977, #13979 !strict.

Note: See TracTickets for help on using tickets.