shrinksafe fails when code uses 'final' keyword

[sgourley]

i was trying to build my.widgets.final.something and was getting an error coming out of shrinksafe saying "missing name after . operator".

fortunately changing final to completed wasn't a big deal for me but ... random?

[bill]

I'd suggest to close as wontfix. Rawld, what do you think?

Besides the fact that we are moving away from shrinksafe to closure, it's completely normal and desirable to get an error message when there's an error in your code. (And in this case, the code has an error because it's using a reserved word.)

[Adam Peller]

Probably fair to classify this as a Shrinksafe bug then, and I'd agree on wontfix. Java reserved words are also reserved in Javascript/ECMAScript, and may cause errors on certain implementations . I think Safari breaks on reserved words?

Hmm... "final" isn't a reserved word, but "finally" is, according to ​https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words

[Rawld Gill]

I also think this is probably a ShrinkSafe? error. Due to 1.7 rel cycle, I'm going to punt this to 1.8 where I'll have a chance to track down and fully understand.

[Adam Peller]

apparently, 'final' is not a reserved word, but it is a "future reserved word" (section 7.5.3) As such, I think this is a wontfix.

[ben hockey]

reopen if needed. closing as wontfix