Opened 8 years ago

Closed 7 years ago

#13967 closed defect (wontfix)

shrinksafe fails when code uses 'final' keyword

Reported by: sgourley Owned by: Rawld Gill
Priority: low Milestone: 1.8
Component: ShrinkSafe Version: 1.6.1
Keywords: build system, shrinksafe, java keywords in namespace Cc: Richard Backhouse
Blocked By: Blocking:

Description

i was trying to build my.widgets.final.something and was getting an error coming out of shrinksafe saying "missing name after . operator".

fortunately changing final to completed wasn't a big deal for me but ... random?

Change History (7)

comment:1 Changed 8 years ago by bill

Owner: set to Rawld Gill

I'd suggest to close as wontfix. Rawld, what do you think?

Besides the fact that we are moving away from shrinksafe to closure, it's completely normal and desirable to get an error message when there's an error in your code. (And in this case, the code has an error because it's using a reserved word.)

comment:2 Changed 8 years ago by Adam Peller

Probably fair to classify this as a Shrinksafe bug then, and I'd agree on wontfix. Java reserved words are also reserved in Javascript/ECMAScript, and may cause errors on certain implementations . I think Safari breaks on reserved words?

Hmm... "final" isn't a reserved word, but "finally" is, according to https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words

comment:3 Changed 8 years ago by Rawld Gill

Milestone: tbd1.8
Priority: normallow
Status: newassigned

I also think this is probably a ShrinkSafe? error. Due to 1.7 rel cycle, I'm going to punt this to 1.8 where I'll have a chance to track down and fully understand.

comment:4 Changed 8 years ago by Adam Peller

Component: GeneralShrinkSafe
Summary: Dojo build system fails when widget has java reserved keyword in namespaceshrinksafe fails when code uses 'final' keyword

comment:5 Changed 8 years ago by Adam Peller

Cc: Richard Backhouse added

comment:6 Changed 8 years ago by Adam Peller

apparently, 'final' is not a reserved word, but it is a "future reserved word" (section 7.5.3) As such, I think this is a wontfix.

comment:7 Changed 7 years ago by ben hockey

Resolution: wontfix
Status: assignedclosed

reopen if needed. closing as wontfix

Note: See TracTickets for help on using tickets.