Opened 8 years ago

Closed 8 years ago

#13939 closed defect (fixed)

[regression] dojo.deprecated and dojo.experimental are no longer suppressed when isDebug=false

Reported by: Kenneth G. Franqueiro Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Core Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

This is a behavioral regression from 1.6, but I'm not sure if it's intentional.

In Dojo 1.6 and lower, dojo.deprecated and dojo.experimental calls would only cause console messages if dojoConfig.isDebug is set to true before dojo is loaded.

In trunk, calls to dojo.deprecated and dojo.experimental always output to console. Rather than consulting isDebug, it appears to hinge on the has feature dojo-debug-messages, which is unconditionally set truthy in kernel.js. Perhaps this has test should consult the value of the isDebug config flag (if possible)?

Change History (3)

comment:1 Changed 8 years ago by Adam Peller

Not sure what to say about the change in behavior as it might relate to a "compatibility" promise, but I think there's good reason to at least have these warnings on by default, especially with us pushing towards 2.0.

comment:2 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:3 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [26614]:

always define dojo.deprecated,experimental; give real defs based on has feature dojo-debug-messages or config.isDebug; thanks kgf; fixes #13939; !strict

Note: See TracTickets for help on using tickets.