Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#13897 closed enhancement (fixed)

[patch][cla] Convert dojox.layout.* to AMD format with minimal dependencies

Reported by: Chris Mitchell Owned by: dylan
Priority: high Milestone: 1.9
Component: DojoX Layout Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

Convert dojox.layout.* to AMD format with minimal dependencies

Attachments (2)

patchBaselessConversionGridContainer.diff​ (10.2 KB) - added by Mathevet julien 8 years ago.
patch-13897-Dock.diff​ (3.3 KB) - added by dylan 7 years ago.
Baseless and general clean-up of dojox/layout/Dock

Download all attachments as: .zip

Change History (27)

comment:1 Changed 8 years ago by Chris Mitchell

In [26554]:

refs #13897 convert dojox.layout.TableContainer? to AMD with minimal dependencies \!strict

comment:2 Changed 8 years ago by Chris Mitchell

In [26555]:

refs #13897 convert dojox.layout.ContentPane? to AMD with minimal dependencies \!strict

comment:3 Changed 8 years ago by Chris Mitchell

In [26557]:

refs #13897 convert dojox.layout.ResizeHandle? to AMD with minimal dependencies \!strict

comment:4 Changed 8 years ago by Chris Mitchell

In [26558]:

refs #13897 convert dojox.layout.FloatingPane? to AMD with minimal dependencies \!strict

comment:5 Changed 8 years ago by Chris Mitchell

In [26559]:

refs #13897 convert dojox.layout.DragPane? to AMD with minimal dependencies \!strict

comment:6 Changed 8 years ago by Chris Mitchell

In [26560]:

refs #13897 convert dojox.layout.ExpandoPane? to AMD with minimal dependencies \!strict

comment:7 Changed 8 years ago by Chris Mitchell

In [26561]:

refs #13897 convert dojox.layout.ExpandoPane? to AMD with minimal dependencies \!strict

comment:8 Changed 8 years ago by Chris Mitchell

In [26562]:

refs #13897 convert dojox.layout.RotatorContainer? to AMD with minimal dependencies \!strict

comment:9 Changed 8 years ago by Chris Mitchell

In [26563]:

refs #13897 convert dojox.layout.RadioGroup? to AMD with minimal dependencies \!strict

comment:10 Changed 8 years ago by Chris Mitchell

In [26564]:

refs #13897 convert dojox.layout.ScrollPane? to AMD with minimal dependencies \!strict

comment:11 Changed 8 years ago by Chris Mitchell

In [26565]:

refs #13897 convert dojox.layout.ScrollPane? to AMD with minimal dependencies \!strict

comment:12 Changed 8 years ago by ben hockey

In [26640]:

updated dojox.profile.js to squelch warnings during build.

as packages are converted to AMD, the profile can be updated to reflect
that those packages can now be tagged as AMD for the build.

refs #13897, #12863

comment:215 Changed 8 years ago by liucougar

In [26985]:

refs #13897: fixed AMD conversion error

!strict

comment:216 Changed 8 years ago by Chris Mitchell

should this also go into 1.7.1 branch?

comment:217 Changed 8 years ago by Kenneth G. Franqueiro

In [27238]:

TableContainer?: dijit._Widget -> baseless _WidgetBase, use dom-style and remove _base/html dep, array -> arrayUtil, LayoutWidget? -> _LayoutWidget. Refs #13897, fixes #13831

comment:7 Changed 8 years ago by Kenneth G. Franqueiro

In [27239]:

TableContainer?: backport [27238] to 1.7 branch. Refs #13897, refs #13831

Changed 8 years ago by Mathevet julien

Attachment: patchBaselessConversionGridContainer.diff​ added

comment:8 Changed 8 years ago by bill

In [27366]:

backport typo fix [26985] from to 1.7/ branch, refs #13897 !strict

comment:9 Changed 8 years ago by bill

In [27367]:

baseless conversion of GridContainer, thanks moogle, refs #13897 !strict

comment:10 Changed 7 years ago by Colin Snover

Milestone: 1.8 → 2.0

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

comment:11 Changed 7 years ago by bill

Note that all the modules in dojox/layout are now in AMD format, although they aren't all baseless / minimal dependencies.

Changed 7 years ago by dylan

Attachment: patch-13897-Dock.diff​ added

Baseless and general clean-up of dojox/layout/Dock

comment:12 Changed 7 years ago by dylan

Owner: set to dylan
Status: new → assigned
Summary: Convert dojox.layout.* to AMD format with minimal dependencies → [patch][cla] Convert dojox.layout.* to AMD format with minimal dependencies

comment:13 Changed 7 years ago by Colin Snover

Dylan, is this going in 1.9? dojox/layout/dnd and dojox/layout/BorderContainer are marked as abandoned.

Last edited 7 years ago by Colin Snover (previous) (diff)

comment:14 Changed 7 years ago by dylan

In [30817]:

refs #13897, convert dojox.layout.Dock to use less dependencies, switch from connect to on, etc.

comment:15 Changed 7 years ago by dylan

Milestone: 2.0 → 1.9
Resolution: → fixed
Status: assigned → closed

Added my patch for Dock. The purpose of this ticket (convert dojox/layout/* to AMD) was completed a while back, so I'll close this out.

ext-dijit/layout/StackContainer-touch.js should probably be removed I would think?

comment:16 in reply to:  15 Changed 7 years ago by bill

Replying to dylan:

ext-dijit/layout/StackContainer-touch.js should probably be removed I would think?

I don't know... dijit supports touch devices pretty well but it doesn't go as far as that extension module, which support flicks to change panes.

Note: See TracTickets for help on using tickets.