Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13891 closed defect (fixed)

Remove client-agent sniff tests from has.js

Reported by: Chris Mitchell Owned by: Kris Zyp
Priority: high Milestone: 1.8
Component: Core Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

In dojo/has.js, lines 112 & 113 contain agent sniffing tests for iOS "agent-ios" and Android "agent-android". The android test is incorrect as it should be testing for "Android" in the client agent string. dojo/_base/sniff.js and dojox/mobile/sniff.js contain correct versions of these tests, but use the test names "ios" and "android" rather than agent-xxx. Please remove these two client agent tests from has.js, since browser sniffing is handled by _base/sniff.js (for desktop and mobile) and dojox/mobile/sniff (for mobile-only). There are no references to either of these strings in the dojo source code, but we have some customers that have already tried using these test names and have hit the android bug.

Change History (4)

comment:1 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:2 Changed 8 years ago by Rawld Gill

Owner: changed from Rawld Gill to Kris Zyp
Status: assignednew

Kris--this is your code; could you take a look. Thanks!

comment:3 Changed 8 years ago by Kris Zyp

Resolution: fixed
Status: newclosed

In [27493]:

remove inappropriate browser agent sniffs, fixes #13891 !strict

comment:4 Changed 8 years ago by bill

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.