Opened 8 years ago

Closed 8 years ago

#13880 closed defect (fixed)

dijit.layout.ContentPane and destroyDescendants

Reported by: rmaccracken Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

ContentPane's destroyDescendants function does not accept a preserveDom parameter and always deletes its contents when destroyRecursive is called.

The following line should not be called if preserveDom is true:

dojo.html._emptyNode(this.containerNode);

Also, calls to destroyRecursive within the function should pass the preserveDom parameter.

Change History (3)

comment:1 Changed 8 years ago by rmaccracken

I may discover more, but it looks like StackContainer? has a similar problem. It accepts the preserveDom parameter, but the first thing it does is call removeChild for each tab which removes the content from the DOM. It looks like that call should only be made if preserveDom is false.

comment:2 Changed 8 years ago by bill

Description: modified (diff)
Milestone: tbd1.7
Owner: set to bill
Status: newassigned

I imagine there will be lots of cases when preseveDom doesn't work; note that the definition of destroy says "Note: This will not yet work with _Templated widgets".

I'll update those cases you mentioned though.

comment:3 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

In [26519]:

Fix a few cases of preserveDom parameter not working; still not sure how well it's supported in general. Fixes #13880 !strict.

Note: See TracTickets for help on using tickets.