Opened 11 years ago
Closed 11 years ago
#13880 closed defect (fixed)
dijit.layout.ContentPane and destroyDescendants
Reported by: | rmaccracken | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Dijit | Version: | 1.6.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
ContentPane's destroyDescendants function does not accept a preserveDom parameter and always deletes its contents when destroyRecursive is called.
The following line should not be called if preserveDom is true:
dojo.html._emptyNode(this.containerNode);
Also, calls to destroyRecursive within the function should pass the preserveDom parameter.
Change History (3)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Milestone: | tbd → 1.7 |
Owner: | set to bill |
Status: | new → assigned |
I imagine there will be lots of cases when preseveDom doesn't work; note that the definition of destroy says "Note: This will not yet work with _Templated widgets".
I'll update those cases you mentioned though.
Note: See
TracTickets for help on using
tickets.
I may discover more, but it looks like StackContainer? has a similar problem. It accepts the preserveDom parameter, but the first thing it does is call removeChild for each tab which removes the content from the DOM. It looks like that call should only be made if preserveDom is false.