Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13869 closed defect (fixed)

Missing dojo.require() in themeTester.html

Reported by: Enzo Owned by: nonken
Priority: high Milestone: 1.7
Component: themes Version: 1.6.1
Keywords: Cc:
Blocked By: Blocking:

Description

I'm using intensively the themeTester.html so I've created a layer specially for this page, including all the dojo.require() from there, in a build

However, still some packages are downloaded from my local dojo, outside the layer => It would be nice to include those packages directly into themeTester.html!

Here are the .js the themeTester is loading outside of my layer build:

dijit/Declaration.js
dijit/form/Form.js
dijit/form/ComboButton.js
dijit/form/RadioButton.js
dijit/form/MultiSelect.js
dijit/layout/LayoutContainer.js
dijit/layout/SplitContainer.js

So I guess the missing requires, in themeTester.html, are: (not sure about first one indeed)

dojo.require("dijit.Declaration")
dojo.require("dijit.form.Form")
dojo.require("dijit.form.ComboButton")
dojo.require("dijit.form.RadioButton")
dojo.require("dijit.form.MultiSelect")
dojo.require("dijit.layout.LayoutContainer")
dojo.require("dijit.layout.SplitContainer")

Change History (2)

comment:1 Changed 8 years ago by bill

Milestone: tbd1.7
Resolution: fixed
Status: newclosed

In 1.7 it just uses dijit-all:

require([
	"dojo",
	"dijit/dijit",
	"dijit/dijit-all",
	//"dijit/tests/_testCommon",
	"dojo/parser",
	"dojo/date/locale",
	"dojo/data/ItemFileReadStore",
	"dojo/dnd/Source"], function(dojo, dijit){

and dijit-all has all the modules you mentioned.

comment:2 Changed 8 years ago by Enzo

Thanks

So just for the archive, in order to create a layer for the themeTester.html, we need to parse all dojo.require() from themeTester.html and from dijit-all.js

That way, the layer will contain everything needed (method works on dojo 1.6, and will work on 1.7 and above)

Note: See TracTickets for help on using tickets.