Opened 8 years ago
Closed 4 years ago
#13868 closed defect (patchwelcome)
dojox.image.Magnifier doesn't seem to work
Reported by: | Enzo | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | Dojox | Version: | 1.7.0b1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
I'm using this magnifier on dojo 1.6.1. It works with a local copy of dojo, but doesn't work if I change to dojo CDN
Further more, both following links give js errors: (and magnifier doesn't work at all) http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/image/tests/test_Magnifier.html
http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/image/tests/test_MagnifierLite.html
But if I go to a previous version of dojo, it works online:
http://archive.dojotoolkit.org/dojo-2011-02-01/dojotoolkit/dojox/image/tests/test_Magnifier.html
Change History (9)
comment:1 Changed 8 years ago by
Owner: | changed from Adam Peller to dante |
---|
comment:2 Changed 8 years ago by
Well yes maybe 2 bugs reported into one, but maybe first bug comes from the fact I need to load dojo.js AND also Magnifier.js, in order to be able to do dojo.require('dojox.image.Magnifier'), so maybe this first bug would be vanished as soon as AMD is supported ? dunno...
I'll be able to make further tests asap AMD is supported indeed
comment:4 follow-up: 5 Changed 8 years ago by
Thanks gonna check that
But the file dojox/image/tests/images/spanke.jpg should be added to the changeset also, no? (it exists for http://archive.dojotoolkit.org/dojo-2011-02-01/dojotoolkit/dojox/image/tests/test_Magnifier.html)
comment:5 Changed 8 years ago by
Replying to enzo_4:
But the file dojox/image/tests/images/spanke.jpg should be added to the changeset also, no? (it exists for http://archive.dojotoolkit.org/dojo-2011-02-01/dojotoolkit/dojox/image/tests/test_Magnifier.html)
Probably. I didn't fix the broken images. The ticket remains open.
comment:6 Changed 8 years ago by
Ok for the missing image, not a problem indeed as other images are present in the test_Magnifier.html that let users test the magnifier
However, on http://archive.dojotoolkit.org/dojo-2011-09-09/dojotoolkit/dojox/image/tests/test_Magnifier.html, I can see your changes from changeset 26496, but the magnifier still doesn't work
To be more precise, when I move the mouse over an image, a magnifier is shown but much below in the page (not on the mouse), and it doesn't refresh when I move the mouse
I guess some coords problems to be involved in the bug
comment:7 Changed 8 years ago by
Interesting. The problem you describe appears on FF, only with a build.
Well, the bug remains open.
comment:8 Changed 8 years ago by
Yes, this is exactly my config for this test.
Some remarks that may help, or not, dunno...:
When I check http://archive.dojotoolkit.org/dojo-2011-09-09/dojotoolkit/dojox/image/Magnifier.js, compared to your http://bugs.dojotoolkit.org/browser/dojo/dojox/trunk/image/Magnifier.js?rev=26496
the built .js begins with: define("dojox/image/Magnifier",["dojo/_base/declare",...
and the non built Magnifier.js begins with: define(["dojo/_base/declare",...
=> So here the build process adds a first argument to define(), dunno if it's correct or not...
Another idea is that the build process change the name of the argument of:
function(declare, construct, window, gfx, canvas, MagnifierLite)
with:
function(_1,_2,_3,_4,_5,_6)
but notice window argument that is a reserved name, maybe it can conflict with global window variable on some browsers like FF (and no conflict anymore with the built system that replaces window with _3)
Well really don't know for this problem.. just a couple of ideas, cause I deeply need the Magnifier on my FF :)
comment:9 Changed 4 years ago by
Milestone: | tbd → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
Given that no one has shown interest in creating a patch in the past 4+ years, I'm closing this as patchwelcome.
Looks like multiple bugs reported as one: CDN failure on 1.6, failure on nightlies (likely AMD migration and missing images)