#13854 closed defect (fixed)
Browser-specific patches undefine declaredClass
Reported by: | Adam Peller | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Dijit | Version: | 1.7.0b1 |
Keywords: | Cc: | Douglas Hays | |
Blocked By: | Blocking: |
Description
dijit.form.TextBox has two browser branches (e.g. "dijit.form.TextBox.MozMixin") that declare an anonymous mixin based on TextBox and replace the original class definition. The declaredClass is lost. As a result, TextBox gets a declaredClass of uniq_nnn which breaks back-compat for apps expecting it to be "dijit.form.TextBox"
Setting TextBox.prototype.declaredClass = "dijit.form.TextBox";
after applying the branch fixes the problem. Not sure if that can be wrapped in the declare instead.
Change History (3)
comment:2 Changed 9 years ago by
Owner: | set to bill |
---|---|
Resolution: | → fixed |
Status: | new → closed |
In [26473]:
Note: See
TracTickets for help on using
tickets.
Either
or adding
to the prototype break the tests/_BidiSupport/form/robot/Textarea.html test, among others. In tests/_BidiSupport/form/test_Textarea.html, when the Textarea widgets are created _TextBoxMixin::_setTextDirAttr() calls applyTextDir(), but that call goes to the empty _WidgetBase.applyTextDir() rather than the _BidiSupport.applyTextDir() method.