Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13851 closed enhancement (fixed)

dijit/focus registerIframe/registerWin should return a handle with a remove function

Reported by: Colin Snover Owned by: bill
Priority: high Milestone: 1.7
Component: Dijit Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Colin Snover)

Currently handles that are returned are themselves the remove function. This should be updated to be consistent with other handles in 1.7.

Change History (4)

comment:1 Changed 8 years ago by Colin Snover

Description: modified (diff)

comment:2 Changed 8 years ago by bill

Milestone: tbd1.7
Owner: set to bill
Status: newassigned

Fair enough, I guess we can change it without backwards compatibility issues since the official API is to deregister by calling unregisterWin() / unregisterIframe().

comment:3 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

In [26468]:

Deregister handles via handle.remove() rather than unregisterIframe()/unregisterWin() methods. Old methods left in back-compat module dijit/_base/focus. Refs #12366, fixes #13851 !strict.

comment:7 Changed 8 years ago by bill

In [26495]:

Forgot to update code to deregister via handle.remove() rather than unregisterIframe(), refs #13851 !strict.

Note: See TracTickets for help on using tickets.