#13831 closed enhancement (fixed)
[patch] AMD refactoring of dojox.layout.TableContainer
Reported by: | Kitson Kelly | Owned by: | Kenneth G. Franqueiro |
---|---|---|---|
Priority: | high | Milestone: | 1.7.1 |
Component: | DojoX Layout | Version: | 1.7.0b1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Attached is a refactoring of dojox.layout.TableContainer
. In addition the test_TableContainer.html contained an odd situation where it expressly included the JS file in addition to the dojo.require, which causes some issues when converting to AMD declaration.
Attachments (4)
Change History (12)
Changed 9 years ago by
Attachment: | TableContainer.js.patch added |
---|
Changed 9 years ago by
Attachment: | test_TableContainer.html.patch added |
---|
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
Ok, I think I did a full baseless conversion on it now. It seems to be working. The only thing I am not 100% on is how the extension of dijit._Widget is supposed to work in the baseless world.
Changed 9 years ago by
Attachment: | TableContainer.js.4.patch added |
---|
Ignore patch 3... It was the same as the original. This one...
comment:3 Changed 9 years ago by
I'm attaching another new patch to make delegate
and _Widget
references also baseless. (The process for _Widget
is the same as you already did for _LayoutWidget
.)
Changed 9 years ago by
Attachment: | TableContainer.js.kgf.patch added |
---|
New patch on top of .4 with baseless declare and _Widget
comment:4 Changed 9 years ago by
comment:5 Changed 9 years ago by
Owner: | set to Kenneth G. Franqueiro |
---|
comment:8 Changed 9 years ago by
Milestone: | 1.8 → 1.7.1 |
---|
As moogle pointed out, this was actually "half-fixed" in a commit before 1.7.0 went out, thus I've backported the completion of the conversion for 1.7.1 as well.
I'm attaching a new patch for the js file; since this is not a truly baseless conversion, it would be more appropriate to be requiring
"dojo"
and"dijit"
as dependencies. (Also fixed indentation of requires.)