Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13831 closed enhancement (fixed)

[patch] AMD refactoring of dojox.layout.TableContainer

Reported by: Kitson Kelly Owned by: Kenneth G. Franqueiro
Priority: high Milestone: 1.7.1
Component: DojoX Layout Version: 1.7.0b1
Keywords: Cc:
Blocked By: Blocking:

Description

Attached is a refactoring of dojox.layout.TableContainer. In addition the test_TableContainer.html contained an odd situation where it expressly included the JS file in addition to the dojo.require, which causes some issues when converting to AMD declaration.

Attachments (4)

TableContainer.js.patch (1.1 KB) - added by Kitson Kelly 8 years ago.
test_TableContainer.html.patch (590 bytes) - added by Kitson Kelly 8 years ago.
TableContainer.js.4.patch (7.0 KB) - added by Kitson Kelly 8 years ago.
Ignore patch 3... It was the same as the original. This one…
TableContainer.js.kgf.patch (7.0 KB) - added by Kenneth G. Franqueiro 8 years ago.
New patch on top of .4 with baseless declare and _Widget

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by Kitson Kelly

Attachment: TableContainer.js.patch added

Changed 8 years ago by Kitson Kelly

comment:1 Changed 8 years ago by Kenneth G. Franqueiro

I'm attaching a new patch for the js file; since this is not a truly baseless conversion, it would be more appropriate to be requiring "dojo" and "dijit" as dependencies. (Also fixed indentation of requires.)

comment:2 Changed 8 years ago by Kitson Kelly

Ok, I think I did a full baseless conversion on it now. It seems to be working. The only thing I am not 100% on is how the extension of dijit._Widget is supposed to work in the baseless world.

Changed 8 years ago by Kitson Kelly

Attachment: TableContainer.js.4.patch added

Ignore patch 3... It was the same as the original. This one...

comment:3 Changed 8 years ago by Kenneth G. Franqueiro

I'm attaching another new patch to make declare and _Widget references also baseless. (The process for _Widget is the same as you already did for _LayoutWidget.)

Last edited 8 years ago by Kenneth G. Franqueiro (previous) (diff)

Changed 8 years ago by Kenneth G. Franqueiro

Attachment: TableContainer.js.kgf.patch added

New patch on top of .4 with baseless declare and _Widget

comment:4 Changed 8 years ago by Mathevet julien

Seem to be partially done in #13897 : (In [26554] )

You could merge header to use this header patch and then close it.

comment:5 Changed 8 years ago by bill

Owner: set to Kenneth G. Franqueiro

comment:6 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: newclosed

In [27238]:

TableContainer?: dijit._Widget -> baseless _WidgetBase, use dom-style and remove _base/html dep, array -> arrayUtil, LayoutWidget? -> _LayoutWidget. Refs #13897, fixes #13831

comment:7 Changed 8 years ago by Kenneth G. Franqueiro

In [27239]:

TableContainer?: backport [27238] to 1.7 branch. Refs #13897, refs #13831

comment:8 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: 1.81.7.1

As moogle pointed out, this was actually "half-fixed" in a commit before 1.7.0 went out, thus I've backported the completion of the conversion for 1.7.1 as well.

Note: See TracTickets for help on using tickets.