Changes between Version 1 and Version 2 of Ticket #13828, comment 4


Ignore:
Timestamp:
Sep 6, 2011, 2:04:32 AM (10 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #13828, comment 4

    v1 v2  
    22
    33   - Not sure what "defaultEvent" or "subEvents" attributes in subclasses of gesture/Base is for?    Maybe I'm missing something, but they don't seem necessary.   Likewise with init(), _events and _remove().    I'm just not seeing why you need an infrastructure more complicated than dojo/touch uses.
     4   - You are firing synthetic DOM events as a side effect when on() is called for a node.   Is the idea that an app would call {{{on(node, gesture.swipe, function(){/*empty function*/})}}} and then instead setup handlers on <body> via {{{on(dojo.body(), "swipe.end", ...)}}}?   I don't really see the value here.
    45   - I expected the swipe module to return {move: ..., end: ...} hash rather than being used as swipe (which is the move gesture) and swipe.end.   Although either way works.
    56   - I thought a swipe implied a short, fast gesture but it looks like the swipe code will fire on any touch move, even a long slow one?
    67   - the {{{lang.getObject("gesture", true, dojo);}}} in gesture/Base seems unnecessary
    78   - in tap.js there's a clearTimeout() inside a setTimeout() callback that is unnecessary.
     9   - in the line {{{this.fire(e.target, {type: "tap.doubletap"});}}}, it seems unusual to have an event type containing a dot; it's inconsistent with the browser native event doubleclick (which is called "doubleclick", not "click.doubleclick")