Opened 9 years ago
Closed 9 years ago
#13826 closed defect (fixed)
userConfig.loaderPatch is not mixed in
Reported by: | Patrick Ruzand | Owned by: | Rawld Gill |
---|---|---|---|
Priority: | high | Milestone: | 1.7 |
Component: | Loader | Version: | 1.7.0b1 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description
In dojo.js, l.1574: The call to mix is wrong: mix(req, mix(req, defaultConfig.loaderPatch), userConfig.loaderPatch);
The 3rd argument is ignored by the mix function (whose implementation only considers the first 2):
mix = function(dest, src){
for(var p in src){
dest[p] = src[p];
} return dest;
},
so the userConfig.loaderPatch is never mixed in.
The fix would be to remove the first 'req' parameter :
mix(mix(req, defaultConfig.loaderPatch), userConfig.loaderPatch);
Change History (4)
comment:1 Changed 9 years ago by
Component: | Core → Loader |
---|---|
Owner: | set to Rawld Gill |
comment:2 Changed 9 years ago by
Priority: | normal → high |
---|
comment:3 Changed 9 years ago by
Status: | new → assigned |
---|
Note: See
TracTickets for help on using
tickets.
I assume that's Rawld's code.