Opened 8 years ago

Closed 8 years ago

#13826 closed defect (fixed)

userConfig.loaderPatch is not mixed in

Reported by: Patrick Ruzand Owned by: Rawld Gill
Priority: high Milestone: 1.7
Component: Loader Version: 1.7.0b1
Keywords: Cc: pruzand@…
Blocked By: Blocking:

Description

In dojo.js, l.1574: The call to mix is wrong: mix(req, mix(req, defaultConfig.loaderPatch), userConfig.loaderPatch);

The 3rd argument is ignored by the mix function (whose implementation only considers the first 2):

mix = function(dest, src){

for(var p in src){

dest[p] = src[p];

} return dest;

},

so the userConfig.loaderPatch is never mixed in.

The fix would be to remove the first 'req' parameter :

mix(mix(req, defaultConfig.loaderPatch), userConfig.loaderPatch);

Change History (4)

comment:1 Changed 8 years ago by bill

Component: CoreLoader
Owner: set to Rawld Gill

I assume that's Rawld's code.

comment:2 Changed 8 years ago by Patrick Ruzand

Priority: normalhigh

comment:3 Changed 8 years ago by Rawld Gill

Status: newassigned

comment:4 Changed 8 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [26613]:

fixed typo; fixes #13826; thanks pruzand; !strict

Note: See TracTickets for help on using tickets.